Makefile.pandora
author Sam Lantinga <slouken@libsdl.org>
Wed, 30 Nov 2016 22:06:05 -0800
changeset 10668 1889c850fafc
parent 10203 ed1bad553a56
child 11108 9c7a4a9b79d7
permissions -rw-r--r--
Fixed bug 3340 - SDL_BlitScaled causes access violation in some cases.

Simon Hug

The SDL_BlitScaled function runs into an access violation for specific blit coordinates and surface sizes. The attached testcase blits a 800x600 surface to a 1280x720 surface at the coordinates -640,-345 scaled to 1280x720. The blit function that moves the data then runs over and reads after the pixel data from the src surface causing an access violation.

I can't say where exactly it goes wrong, but I think it could have something to do with the rounding in SDL_UpperBlitScaled. final_src.y is 288 and final_src.h is 313. Together that's 601, which I believe is one too much, but I just don't know the code enough to make sure that's the problem.

Sylvain

I think this patch fix the issue, but maybe it's worth re-writing "SDL_UpperBlitScaled" using SDL_FRect.
     1 # Makefile to build the pandora SDL library
     2 
     3 AR	= arm-none-linux-gnueabi-ar
     4 RANLIB	= arm-none-linux-gnueabi-ranlib
     5 CC = arm-none-linux-gnueabi-gcc
     6 CXX = arm-none-linux-gnueabi-g++
     7 STRIP = arm-none-linux-gnueabi-strip
     8 
     9 CFLAGS  = -O3 -march=armv7-a -mcpu=cortex-a8 -mtune=cortex-a8 -mfloat-abi=softfp \
    10 	-mfpu=neon -ftree-vectorize -ffast-math -fomit-frame-pointer -fno-strict-aliasing -fsingle-precision-constant \
    11 	-I./include -I$(PNDSDK)/usr/include -DSDL_REVISION=0
    12 
    13 TARGET  = libSDL.a
    14 
    15 SOURCES = ./src/*.c ./src/audio/*.c ./src/cpuinfo/*.c ./src/events/*.c \
    16 	./src/file/*.c ./src/stdlib/*.c ./src/thread/*.c ./src/timer/*.c ./src/video/*.c \
    17 	./src/joystick/*.c ./src/haptic/*.c ./src/power/*.c ./src/video/dummy/*.c ./src/audio/disk/*.c \
    18 	./src/audio/dummy/*.c ./src/loadso/dlopen/*.c ./src/audio/dsp/*.c \
    19 	./src/thread/pthread/SDL_systhread.c ./src/thread/pthread/SDL_syssem.c \
    20 	./src/thread/pthread/SDL_sysmutex.c ./src/thread/pthread/SDL_syscond.c \
    21 	./src/joystick/linux/*.c ./src/haptic/linux/*.c ./src/timer/unix/*.c \
    22 	./src/atomic/*.c ./src/filesystem/unix/*.c \
    23 	./src/video/pandora/SDL_pandora.o ./src/video/pandora/SDL_pandora_events.o ./src/video/x11/*.c 
    24 	
    25 
    26 OBJECTS = $(shell echo $(SOURCES) | sed -e 's,\.c,\.o,g')
    27 
    28 CONFIG_H = $(shell cp include/SDL_config_pandora.h include/SDL_config.h && touch include/SDL_revision.h)
    29 
    30 all: $(TARGET)
    31 
    32 $(TARGET): $(CONFIG_H) $(OBJECTS)
    33 	$(AR) crv $@ $^
    34 	$(RANLIB) $@
    35 
    36 clean:
    37 	rm -f $(TARGET) $(OBJECTS)