author Sam Lantinga <>
Wed, 30 Nov 2016 22:06:05 -0800
changeset 10668 1889c850fafc
parent 9998 f67cf37e9cd4
child 10737 3406a0f8b041
permissions -rw-r--r--
Fixed bug 3340 - SDL_BlitScaled causes access violation in some cases.

Simon Hug

The SDL_BlitScaled function runs into an access violation for specific blit coordinates and surface sizes. The attached testcase blits a 800x600 surface to a 1280x720 surface at the coordinates -640,-345 scaled to 1280x720. The blit function that moves the data then runs over and reads after the pixel data from the src surface causing an access violation.

I can't say where exactly it goes wrong, but I think it could have something to do with the rounding in SDL_UpperBlitScaled. final_src.y is 288 and final_src.h is 313. Together that's 601, which I believe is one too much, but I just don't know the code enough to make sure that's the problem.


I think this patch fix the issue, but maybe it's worth re-writing "SDL_UpperBlitScaled" using SDL_FRect.
     2 Simple DirectMedia Layer
     3 Copyright (C) 1997-2016 Sam Lantinga <>
     5 This software is provided 'as-is', without any express or implied
     6 warranty.  In no event will the authors be held liable for any damages
     7 arising from the use of this software.
     9 Permission is granted to anyone to use this software for any purpose,
    10 including commercial applications, and to alter it and redistribute it
    11 freely, subject to the following restrictions:
    13 1. The origin of this software must not be misrepresented; you must not
    14    claim that you wrote the original software. If you use this software
    15    in a product, an acknowledgment in the product documentation would be
    16    appreciated but is not required. 
    17 2. Altered source versions must be plainly marked as such, and must not be
    18    misrepresented as being the original software.
    19 3. This notice may not be removed or altered from any source distribution.