build-scripts/updaterev.sh
author Sam Lantinga <slouken@libsdl.org>
Sun, 17 Aug 2014 14:57:52 -0700
changeset 9086 c5e33f9a0d03
parent 6994 06f368666c6f
permissions -rwxr-xr-x
Fixed bug 2655 - OSX: Window position and global mouse coord spaces are different

Tim McDaniel

On OSX, with revision 8729, the coordinate space for window position and the coordinate space for global mouse position don't match. For a non-fullscreen window, the window position is global relative to the bottom of the menubar. The global mouse position is relative to the top of the screen. This affects Cocoa_WarpMouse and potentially other things as well. Further, the coordinate system for window position is now affected by what screen it is on. For example, if I have two equal size screens oriented side by side such that the tops of the screens are equal in global space, with the menubar on one screen, and a window straddles the two screens, the window's y position makes no sense. The window's y position depends on what screen "most" of the window is on. So if I move the window horizontally just a bit, the y position of my window is now different by the size of the menubar, even though the window was not moved vertically.

I'd like to reiterate that this was a fairly fundamental change (and a breaking change for us). If SDL OSX is to really support multi-display configurations, this is especially problematic.

If the real concern is preventing windows from going under the menubar, then perhaps a solution involving something like overriding [NSWindow constrainFrameRect] would be less problematic than redefining the global window coord space for the main display.
slouken@2982
     1
#!/bin/sh
slouken@2982
     2
#
slouken@2982
     3
# Generate a header file with the current source revision
slouken@2982
     4
slouken@5310
     5
outdir=`pwd`
slouken@2982
     6
cd `dirname $0`
slouken@2982
     7
srcdir=..
slouken@5310
     8
header=$outdir/include/SDL_revision.h
slouken@2982
     9
slouken@5345
    10
rev=`sh showrev.sh 2>/dev/null`
slouken@4936
    11
if [ "$rev" != "" -a "$rev" != "hg-0:baadf00d" ]; then
slouken@5359
    12
    revnum=`echo $rev | sed 's,hg-\([0-9]*\).*,\1,'`
aschiffler@6994
    13
    echo "#define SDL_REVISION \"$rev\"" >"$header.new"
aschiffler@6994
    14
    echo "#define SDL_REVISION_NUMBER $revnum" >>"$header.new"
slouken@2982
    15
    if diff $header $header.new >/dev/null 2>&1; then
aschiffler@6994
    16
        rm "$header.new"
slouken@2982
    17
    else
aschiffler@6994
    18
        mv "$header.new" "$header"
slouken@2982
    19
    fi
slouken@2982
    20
fi