README-psp.txt
author Sam Lantinga <slouken@libsdl.org>
Thu, 01 Aug 2013 09:15:36 -0700
changeset 7563 c128ed448c30
parent 7222 2435b221d77d
permissions -rw-r--r--
Fixed bug 1968 - SDL_RenderCopy stretch loses proportion on viewport boundaries for 3D renderers

driedfruit

SDL_RenderCopy clips dstrect against the viewport. Then it adjusts the
srcrect by "appropriate" amount of pixels. This amount is actually
wrong, quite a lot, because of the rounding errors introduced in the "*
factor / factor" scale.

real_srcrect.x += (deltax * real_srcrect.w) / dstrect->w;
real_srcrect.w += (deltaw * real_srcrect.w) / dstrect->w;

For example:

I have a 32 x 32 srcrect and a 64 x 64 dstrect. So far the
stretching is done perfectly, by a factor of 2.

Now, consider dstrect being clipped against the viewport, so it becomes
56 x 64. Now, the factor becomes 1.75 ! The adjustment to "srcrect"
can't handle this, cause srcrect is in integers.

And thus we now have incorrect mapping, with dstrect not being in the
right proportion to srcrect.

The problem is most evident when upscaling stuff, like displaying a 8x8
texture with a zoom of 64 or more, and moving it beyond the corners of
the screen. It *looks* really really bad.

Note: RenderCopyEX does no such clipping, and is right to do so. The fix would be to remove any such clipping from RenderCopy too. And then fix the software renderer, because it has the same fault, independently of RenderCopy.

[attached patch]
this leaves Software Renderer buggy, as it does it's own clipping later on
slouken@7222
     1
SDL port for the Sony PSP contributed by 
slouken@7222
     2
   Captian Lex 
slouken@7222
     3
slouken@7222
     4
Credit to
slouken@7222
     5
   Marcus R.Brown,Jim Paris,Matthew H for the original SDL 1.2 for PSP
slouken@7222
     6
   Geecko for his PSP GU lib "Glib2d"
slouken@7222
     7
slouken@7222
     8
Building
slouken@7222
     9
--------
slouken@7222
    10
To build for the PSP, make sure psp-config is in the path and run:
slouken@7222
    11
   make -f Makefile.psp
slouken@7222
    12
slouken@7222
    13
slouken@7222
    14
slouken@7222
    15
To Do
slouken@7222
    16
------
slouken@7222
    17
PSP Screen Keyboard