CREDITS
author Sam Lantinga <slouken@libsdl.org>
Mon, 02 Jun 2003 14:50:22 +0000
changeset 632 85e104fe14c2
parent 470 877b992f2d0c
child 827 b10aeac509ea
permissions -rw-r--r--
Date: Sun, 1 Jun 2003 15:38:45 -0700 (PDT)
From: Jeff Brown <jabrown@caida.org>
Subject: [patch] SDL-1.2.5 + FreeBSD joystick axes, hat fixes

Hello again! When I sent in some SDL fixes last December, I found out
they'd already been fixed in the CVS version. This time, I checked the
repository before bugging you. =)

I'm using SDL-1.2.5 on a FreeBSD 4.6.2-RELEASE system, and in the course
of getting my multi-analog-axis USB controller (with a hat switch!)
working with d2x-sdl -- the SDL port of the Descent 2 engine -- I came
across a few problems:

1) The second analog stick is reported as a slider in one direction, and
"Rz" in the other. SDL was ignoring the Rz axis, so I added Rx/Ry/Rz to
the set of things SDL considers to be axes.

2) After the above change, the set of JOYAXE_* axes for my gamepad was
{0,1,3,7}; however, d2x-sdl expects the axes to be contiguously numbered
from 0, which seems like a pretty reasonable expectation, rather than
having to scan the entire space of axes that SDL may or may not have.
So, I added a table lookup which maps the JOYAXE_* axis numbers to 0,1,...
in the order they're detected by SDL_SYS_JoystickOpen(), when reporting
them to the application. I also added a function "usage_to_joyaxe()"
which maps the USB HUG_* usage values to JOYAXE_values, since the repeated
case statements testing for HUG_* were getting out of hand.

3) The BSD joystick driver had no hat support, so I added it. It looks
like our USB library can only support one hat switch per device, which
makes life easy.

The patch against SDL-1.2.5 which implements these changes is at:

http://www.caida.org/~jabrown/patches/sdl-1.2.5-bsdhat.diff

After applying, SDL's "testjoystick" reports all activity from my gamepad
correctly, and d2x works too (though it needed some other fixes).

Moving on...

There is also a problem with slightly different USBHID library interfaces
on different versions of FreeBSD. I wasn't going to mention this since the
FreeBSD port for SDL-1.2.5 (and not SDL itself) was doing the FreeBSD
version-specific patching, so I e-mailed the port maintainer with this
change. However, I see that you've incorporated the FreeBSD
version-checking stuff into the CVS version of SDL, so now it's relevant
for you too.

The problem is, the FreeBSD #if tests don't work right for FreeBSD
4.6.2-RELEASE. There may be other versions with this problem, but I've
only tested 4.6.2-R. The following patch against your latest CVS version
fixes this:

--- SDL_sysjoystick.c-1.16 Tue Apr 15 09:02:08 2003
+++ SDL_sysjoystick.c Sun Jun 1 15:10:28 2003
@@ -420,6 +420,8 @@
# else
len = hid_report_size(rd, repinfo[repind].kind, r->rid);
# endif
+# elif (__FreeBSD_version == 460002)
+ len = hid_report_size(rd, r->rid, repinfo[repind].kind);
# else
len = hid_report_size(rd, repinfo[repind].kind, &r->rid);
#endif


I hope this is all useful to you. I've been getting myself dizzy playing
Descent 2 with it, all morning!

-Jeff Brown


P.S. My USB controller is a Thrustmaster Firestorm Dual Analog 2. That's
probably irrelevant, but I threw it in for completeness.
slouken@0
     1
slouken@0
     2
Simple DirectMedia Layer CREDITS
slouken@0
     3
Thanks to everyone who made this possible, including:
slouken@0
     4
slouken@0
     5
* Cliff Matthews, for giving me a reason to start this project. :)
slouken@0
     6
 -- Executor rocks!  *grin*
slouken@0
     7
slouken@159
     8
* Scott Call, for making a home for SDL on the 'Net... Thanks! :)
slouken@0
     9
slouken@470
    10
* The Linux Fund, C Magazine, and Gareth Noyce for financial contributions
slouken@159
    11
slouken@470
    12
* Gaëtan de Menten for writing the PHP and SQL behind the SDL website
slouken@470
    13
slouken@470
    14
* Martin Donlon for his work on the SDL Documentation Project
slouken@470
    15
slouken@470
    16
* Ryan Gordon for helping everybody out and keeping the dream alive. :)
slouken@470
    17
slouken@470
    18
* Mattias Engdegård, for help with the Solaris port and lots of other help
slouken@159
    19
slouken@159
    20
* Max Watson, Matt Slot, and Kyle for help with the MacOS Classic port
slouken@159
    21
slouken@159
    22
* Stan Shebs, for the initial MacOS X port
slouken@159
    23
slouken@159
    24
* Max Horn and Darrell Walisser for unflagging work on the MacOS X port
slouken@0
    25
slouken@470
    26
* Patrick Trainor, Jim Boucher, and Mike Gorchak for the QNX Neutrino port
slouken@0
    27
slouken@281
    28
* Carsten Griwodz for the AIX port
slouken@250
    29
slouken@0
    30
* Gabriele Greco, for the Amiga port
slouken@0
    31
slouken@281
    32
* Patrice Mandin, for the Atari port
slouken@281
    33
slouken@281
    34
* Hannu Viitala for the EPOC port
slouken@0
    35
slouken@159
    36
* Peter Valchev for nagging me about the OpenBSD port until I got it right. :)
slouken@0
    37
slouken@0
    38
* Kent B Mein, for a place to do the IRIX port
slouken@0
    39
slouken@0
    40
* Ash, for a place to do the OSF/1 Alpha port
slouken@0
    41
slouken@0
    42
* David Sowsy, for help with the BeOS port
slouken@0
    43
slouken@159
    44
* Eugenia Loli, for endless work on porting SDL games to BeOS
slouken@0
    45
slouken@0
    46
* Jon Taylor for the GGI front-end
slouken@0
    47
slouken@0
    48
* Paulus Esterhazy, for the Visual C++ testing and libraries
slouken@0
    49
slouken@0
    50
* Brenda Tantzen, for Metrowerks CodeWarrior on MacOS
slouken@0
    51
slouken@0
    52
* Chris Nentwich, for the Hermes assembly blitters
slouken@0
    53
slouken@0
    54
* Michael Vance and Jim Kutter for the X11 OpenGL support
slouken@0
    55
slouken@470
    56
* Stephane Peter, for the AAlib front-end and multi-threaded timer idea.
slouken@470
    57
slouken@470
    58
* Jon Atkins for great SDL_net and SDL_mixer documentation
slouken@470
    59
slouken@0
    60
* Peter Wiklund, for the 1998 winning SDL logo,
slouken@0
    61
  and Arto Hamara, Steven Wong, and Kent Mein for other logo entries.
slouken@0
    62
slouken@470
    63
* Everybody at Loki Software, Inc. for their great contributions!
slouken@0
    64
slouken@0
    65
 And a big hand to everyone else who gave me appreciation, advice,
slouken@0
    66
 and suggestions, especially the good folks on the SDL mailing list.
slouken@0
    67
slouken@0
    68
THANKS! :)
slouken@0
    69
slouken@0
    70
  -- Sam Lantinga			<slouken@libsdl.org>
slouken@0
    71