TODO.txt
author Philipp Wiesemann <philipp.wiesemann@arcor.de>
Thu, 16 Apr 2015 22:04:35 +0200
changeset 9563 537881242756
parent 7856 cb37776926ad
permissions -rw-r--r--
Fixed return value of SDL_SaveBMP_RW() depending on set errors after NULL input.

If SDL_SaveBMP_RW() was called with NULL passed as SDL_RWops argument, different
values were returned depending on SDL_GetError(). If no error was set before the
call (or SDL_ClearError() was called) then 0 was returned. This is wrong because
nothing was saved. If an error was set before the call then -1 was returned.

This was fixed by directly returning -1 for NULL input instead of deciding based
on SDL_GetError(). No new error is set because this would otherwise override a
maybe more useful error set in SDL_RWFromFile() which is used by SDL_SaveBMP().
slouken@7222
     1
Future work roadmap:
slouken@7222
     2
 * http://wiki.libsdl.org/moin.cgi/Roadmap
slouken@7222
     3
slouken@7222
     4
 * Check 1.2 revisions:
slouken@7222
     5
	3554 - Need to resolve semantics for locking keys on different platforms
slouken@7222
     6
	4874 - Do we want screen rotation?  At what level?
slouken@7222
     7
	4974 - Windows file code needs to convert UTF-8 to Unicode, but we don't need to tap dance for Windows 95/98
slouken@7222
     8
	4865 - See if this is still needed (mouse coordinate clamping)
slouken@7222
     9
	4866 - See if this is still needed (blocking window repositioning)
slouken@7222
    10