COPYING.txt
author Philipp Wiesemann <philipp.wiesemann@arcor.de>
Thu, 16 Apr 2015 22:04:35 +0200
changeset 9563 537881242756
parent 8149 681eb46b8ac4
child 9619 b94b6d0bff0f
permissions -rw-r--r--
Fixed return value of SDL_SaveBMP_RW() depending on set errors after NULL input.

If SDL_SaveBMP_RW() was called with NULL passed as SDL_RWops argument, different
values were returned depending on SDL_GetError(). If no error was set before the
call (or SDL_ClearError() was called) then 0 was returned. This is wrong because
nothing was saved. If an error was set before the call then -1 was returned.

This was fixed by directly returning -1 for NULL input instead of deciding based
on SDL_GetError(). No new error is set because this would otherwise override a
maybe more useful error set in SDL_RWFromFile() which is used by SDL_SaveBMP().
slouken@7222
     1
slouken@7222
     2
Simple DirectMedia Layer
slouken@8149
     3
Copyright (C) 1997-2014 Sam Lantinga <slouken@libsdl.org>
slouken@7222
     4
  
slouken@7222
     5
This software is provided 'as-is', without any express or implied
slouken@7222
     6
warranty.  In no event will the authors be held liable for any damages
slouken@7222
     7
arising from the use of this software.
slouken@7222
     8
slouken@7222
     9
Permission is granted to anyone to use this software for any purpose,
slouken@7222
    10
including commercial applications, and to alter it and redistribute it
slouken@7222
    11
freely, subject to the following restrictions:
slouken@7222
    12
  
slouken@7222
    13
1. The origin of this software must not be misrepresented; you must not
slouken@7222
    14
   claim that you wrote the original software. If you use this software
slouken@7222
    15
   in a product, an acknowledgment in the product documentation would be
slouken@7222
    16
   appreciated but is not required. 
slouken@7222
    17
2. Altered source versions must be plainly marked as such, and must not be
slouken@7222
    18
   misrepresented as being the original software.
slouken@7222
    19
3. This notice may not be removed or altered from any source distribution.
slouken@7222
    20