src/audio/pulseaudio/SDL_pulseaudio.h
author Sam Lantinga
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6885 700f1b25f77f
child 8093 b43765095a6f
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
icculus@2271
     1
/*
slouken@5535
     2
  Simple DirectMedia Layer
slouken@6885
     3
  Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
icculus@2271
     4
slouken@5535
     5
  This software is provided 'as-is', without any express or implied
slouken@5535
     6
  warranty.  In no event will the authors be held liable for any damages
slouken@5535
     7
  arising from the use of this software.
icculus@2271
     8
slouken@5535
     9
  Permission is granted to anyone to use this software for any purpose,
slouken@5535
    10
  including commercial applications, and to alter it and redistribute it
slouken@5535
    11
  freely, subject to the following restrictions:
icculus@2271
    12
slouken@5535
    13
  1. The origin of this software must not be misrepresented; you must not
slouken@5535
    14
     claim that you wrote the original software. If you use this software
slouken@5535
    15
     in a product, an acknowledgment in the product documentation would be
slouken@5535
    16
     appreciated but is not required.
slouken@5535
    17
  2. Altered source versions must be plainly marked as such, and must not be
slouken@5535
    18
     misrepresented as being the original software.
slouken@5535
    19
  3. This notice may not be removed or altered from any source distribution.
icculus@2271
    20
*/
icculus@2271
    21
#include "SDL_config.h"
icculus@2271
    22
icculus@2271
    23
#ifndef _SDL_pulseaudio_h
icculus@2271
    24
#define _SDL_pulseaudio_h
icculus@2271
    25
icculus@2271
    26
#include <pulse/simple.h>
icculus@2271
    27
icculus@2271
    28
#include "../SDL_sysaudio.h"
icculus@2271
    29
icculus@2271
    30
/* Hidden "this" pointer for the audio functions */
icculus@3672
    31
#define _THIS SDL_AudioDevice *this
icculus@2271
    32
icculus@2271
    33
struct SDL_PrivateAudioData
icculus@2271
    34
{
icculus@3672
    35
    /* pulseaudio structures */
icculus@3672
    36
    pa_mainloop *mainloop;
icculus@3672
    37
    pa_mainloop_api *mainloop_api;
icculus@3672
    38
    pa_context *context;
icculus@3672
    39
    pa_stream *stream;
icculus@2271
    40
icculus@2271
    41
    /* Raw mixing buffer */
icculus@2271
    42
    Uint8 *mixbuf;
icculus@2271
    43
    int mixlen;
icculus@2271
    44
};
icculus@2271
    45
icculus@2271
    46
#endif /* _SDL_pulseaudio_h */
icculus@2271
    47
icculus@2271
    48
/* vi: set ts=4 sw=4 expandtab: */