src/SDL_hints_c.h
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6885 700f1b25f77f
child 7191 75360622e65f
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
tim@5556
     1
/*
tim@5556
     2
 Simple DirectMedia Layer
slouken@6885
     3
 Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
tim@5556
     4
 
tim@5556
     5
 This software is provided 'as-is', without any express or implied
tim@5556
     6
 warranty.  In no event will the authors be held liable for any damages
tim@5556
     7
 arising from the use of this software.
tim@5556
     8
 
tim@5556
     9
 Permission is granted to anyone to use this software for any purpose,
tim@5556
    10
 including commercial applications, and to alter it and redistribute it
tim@5556
    11
 freely, subject to the following restrictions:
tim@5556
    12
 
tim@5556
    13
 1. The origin of this software must not be misrepresented; you must not
tim@5556
    14
 claim that you wrote the original software. If you use this software
tim@5556
    15
 in a product, an acknowledgment in the product documentation would be
tim@5556
    16
 appreciated but is not required.
tim@5556
    17
 2. Altered source versions must be plainly marked as such, and must not be
tim@5556
    18
 misrepresented as being the original software.
tim@5556
    19
 3. This notice may not be removed or altered from any source distribution.
tim@5556
    20
 */
tim@5556
    21
tim@5556
    22
#ifndef _SDL_hints_c_h
tim@5556
    23
#define _SDL_hints_c_h
tim@5556
    24
tim@5556
    25
/**
tim@5556
    26
 *  \brief  A callback function that is optionally called when a hint changes
tim@5556
    27
 */
tim@5556
    28
typedef void (*SDL_HintChangedCb)(const char *name, const char *oldValue, const char *newValue);
tim@5556
    29
tim@5556
    30
extern SDL_bool SDL_RegisterHintChangedCb(const char *name, SDL_HintChangedCb hintCb);
tim@5556
    31
tim@5556
    32
#endif /* _SDL_hints_c_h */
tim@5556
    33
icculus@5878
    34
/* vi: set ts=4 sw=4 expandtab: */