README.pandora
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6987 7084af936d82
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
slouken@6251
     1
SDL 2.0 with open pandora console support ( http://openpandora.org/ )
slouken@3161
     2
=====================================================================
slouken@3161
     3
slouken@6987
     4
- A pandora specific video driver was written to allow SDL 2.0 with OpenGL ES
slouken@3161
     5
support to work on the pandora under the framebuffer. This driver do not have
slouken@3161
     6
input support for now, so if you use it you will have to add your own control code.
slouken@3161
     7
The video driver name is "pandora" so if you have problem running it from
slouken@3161
     8
the framebuffer, try to set the following variable before starting your application :
slouken@3161
     9
"export SDL_VIDEODRIVER=pandora"
slouken@3161
    10
slouken@3161
    11
- OpenGL ES support was added to the x11 driver, so it's working like the normal
slouken@3161
    12
x11 driver one with OpenGLX support, with SDL input event's etc..
slouken@3161
    13
slouken@3161
    14
slouken@3161
    15
David Carré (Cpasjuste)
slouken@3161
    16
cpasjuste@gmail.com