README-SDL.txt
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6987 7084af936d82
child 7222 2435b221d77d
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
slouken@0
     1
slouken@0
     2
Please distribute this file with the SDL runtime environment:
slouken@0
     3
slouken@6987
     4
The Simple DirectMedia Layer (SDL for short) is a cross-platform library
slouken@0
     5
designed to make it easy to write multi-media software, such as games and
slouken@0
     6
emulators.
slouken@0
     7
slouken@0
     8
The Simple DirectMedia Layer library source code is available from:
slouken@0
     9
http://www.libsdl.org/
slouken@0
    10
slouken@5537
    11
This library is distributed under the terms of the zlib license:
slouken@5537
    12
http://www.zlib.net/zlib_license.html
slouken@0
    13