Makefile.minimal
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 5310 a9945ce48999
child 7667 be1cc6f55840
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
slouken@1484
     1
# Makefile to build the SDL library
slouken@1484
     2
slouken@1484
     3
INCLUDE = -I./include
slouken@1484
     4
CFLAGS  = -g -O2 $(INCLUDE)
slouken@1484
     5
AR	= ar
slouken@1484
     6
RANLIB	= ranlib
slouken@1484
     7
slouken@1484
     8
TARGET  = libSDL.a
slouken@1484
     9
SOURCES = \
slouken@1484
    10
	src/*.c \
slouken@1484
    11
	src/audio/*.c \
slouken@5310
    12
	src/audio/dummy/*.c \
slouken@1484
    13
	src/cpuinfo/*.c \
slouken@1484
    14
	src/events/*.c \
slouken@1484
    15
	src/file/*.c \
slouken@5310
    16
	src/haptic/*.c \
slouken@5310
    17
	src/haptic/dummy/*.c \
slouken@1484
    18
	src/joystick/*.c \
slouken@5310
    19
	src/joystick/dummy/*.c \
slouken@5310
    20
	src/loadso/dummy/*.c \
slouken@5310
    21
	src/power/*.c \
slouken@5310
    22
	src/render/*.c \
slouken@5310
    23
	src/render/software/*.c \
slouken@1484
    24
	src/stdlib/*.c \
slouken@1484
    25
	src/thread/*.c \
slouken@5310
    26
	src/thread/generic/*.c \
slouken@1484
    27
	src/timer/*.c \
slouken@5310
    28
	src/timer/dummy/*.c \
slouken@1484
    29
	src/video/*.c \
slouken@1484
    30
	src/video/dummy/*.c \
slouken@1484
    31
slouken@1484
    32
OBJECTS = $(shell echo $(SOURCES) | sed -e 's,\.c,\.o,g')
slouken@1484
    33
slouken@1484
    34
all: $(TARGET)
slouken@1484
    35
slouken@5310
    36
$(TARGET): $(OBJECTS)
slouken@1484
    37
	$(AR) crv $@ $^
slouken@1484
    38
	$(RANLIB) $@
slouken@1484
    39
slouken@1484
    40
clean:
slouken@1484
    41
	rm -f $(TARGET) $(OBJECTS)