Makefile.minimal
author Sam Lantinga <slouken@libsdl.org>
Thu, 17 Apr 2014 22:36:14 -0700
branchSDL-1.2
changeset 8716 0aade9c0203f
parent 1603 64710b9f3eeb
child 2494 a72a5f62d6b7
permissions -rw-r--r--
Fixed bug 2325 - SDL_EnableUNICODE sometimes drops keyboard events completely

Rafał Mużyło

The most annoying part of this bug is that though I've found it in two separate apps, I don't have a trivial testcase for it.

The problem seems to be a condition race, as it's triggered quite randomly (therefore it will be hard to tell whether it really gets fixed, if a probable fix is found).

While it's specific to SDL 1.2, it seems quite similar to the problem described and fixed in http://forums.libsdl.org/viewtopic.php?p=40503.

Now, I should start describing the problem.

A game uses Escape to open menu (the exact key might not be important). Upon opening, it calls SDL_EnableUNICODE(1). Upon closing it calls SDL_EnableUNICODE(0).

I have an IME running.

Game uses SDL_PollEvent to get the events.

If Escape is pressed repeatedly, menu is opened and closed, till it eventually freezes in open state.
"freezes" in this context means "app itself still runs, but no keyboard events are getting delivered (though - for example - mouse events still are)". "getting delivered" should mean "SDL_PollEvent is not receiving any".
If it matters, the last delivered keyboard event is a keypress, the release never arrives.

It seems (no guarantees, due to random nature of the freeze) that unsetting XMODIFIERS (which - AFAIU - will disable IME as far as SDL is concerned) prevents the freeze, therefore the reference to that SDL2 thread.
slouken@1484
     1
# Makefile to build the SDL library
slouken@1484
     2
slouken@1484
     3
INCLUDE = -I./include
slouken@1484
     4
CFLAGS  = -g -O2 $(INCLUDE)
slouken@1484
     5
AR	= ar
slouken@1484
     6
RANLIB	= ranlib
slouken@1484
     7
slouken@1603
     8
CONFIG_H = include/SDL_config.h
slouken@1484
     9
TARGET  = libSDL.a
slouken@1484
    10
SOURCES = \
slouken@1484
    11
	src/*.c \
slouken@1484
    12
	src/audio/*.c \
slouken@1484
    13
	src/cdrom/*.c \
slouken@1484
    14
	src/cpuinfo/*.c \
slouken@1484
    15
	src/events/*.c \
slouken@1484
    16
	src/file/*.c \
slouken@1484
    17
	src/joystick/*.c \
slouken@1484
    18
	src/stdlib/*.c \
slouken@1484
    19
	src/thread/*.c \
slouken@1484
    20
	src/timer/*.c \
slouken@1484
    21
	src/video/*.c \
slouken@1533
    22
	src/audio/dummy/*.c \
slouken@1484
    23
	src/video/dummy/*.c \
slouken@1484
    24
	src/joystick/dummy/*.c \
slouken@1484
    25
	src/cdrom/dummy/*.c \
slouken@1484
    26
	src/thread/generic/*.c \
slouken@1484
    27
	src/timer/dummy/*.c \
slouken@1484
    28
	src/loadso/dummy/*.c \
slouken@1484
    29
slouken@1484
    30
OBJECTS = $(shell echo $(SOURCES) | sed -e 's,\.c,\.o,g')
slouken@1484
    31
slouken@1484
    32
all: $(TARGET)
slouken@1484
    33
slouken@1603
    34
$(TARGET): $(CONFIG_H) $(OBJECTS)
slouken@1484
    35
	$(AR) crv $@ $^
slouken@1484
    36
	$(RANLIB) $@
slouken@1484
    37
slouken@1603
    38
$(CONFIG_H):
slouken@1603
    39
	cp $(CONFIG_H).default $(CONFIG_H)
slouken@1603
    40
slouken@1484
    41
clean:
slouken@1484
    42
	rm -f $(TARGET) $(OBJECTS)