Fixed bug 3018 - Loading MIDI music using FluidSynth leaks memory.

Philipp Wiesemann There is a memory leak in fluidsynth.c and fluidsynth_loadsong_RW_internal(). The allocated temporary buffer is not deleted if fluid_player_add_mem() returns FLUID_OK.
libsdl-org · Jun 17, 2015 · 169f565 · 169f565
1 parent 0d01421
commit 169f565
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/fluidsynth.c b/fluidsynth.c
@@ -124,6 +124,7 @@ static int fluidsynth_loadsong_RW_internal(FluidSynthMidiSong *song, void *data)
     if ((buffer = (char*) SDL_malloc(size))) {
         if(SDL_RWread(src, buffer, size, 1) == 1) {
             if (fluidsynth.fluid_player_add_mem(song->player, buffer, size) == FLUID_OK) {
+                SDL_free(buffer);
                 return 1;
             } else {
                 Mix_SetError("FluidSynth failed to load in-memory song");