Fixed bug 2142 - missing include of dynamic_fluidsynth.h in mixer.c
authorSam Lantinga <slouken@libsdl.org>
Sun, 13 Oct 2013 20:03:03 -0700
changeset 6658b25e64c7ac7
parent 664 8a04342cf1e1
child 666 c166c70fc52a
Fixed bug 2142 - missing include of dynamic_fluidsynth.h in mixer.c

manuel.montezelo

I think that mixer is not including dynamic_fluidsynth.h in this block:

#include "SDL_mixer.h"
#include "load_aiff.h"
#include "load_voc.h"
#include "load_ogg.h"
#include "load_flac.h"
#include "dynamic_flac.h"
#include "dynamic_modplug.h"
#include "dynamic_mod.h"
#include "dynamic_mp3.h"
#include "dynamic_ogg.h"

So the compiler then generates these warnings (as spotted in [1]):

[1] http://qa.debian.org/bls/packages/l/libsdl2-mixer.html

W implicit-declaration mixer.c:154
W implicit-declaration mixer.c:215

I don't think that there's a big problem unless, but anyway, it probably should be fixed to avoid possible problems in the future.
mixer.c
     1.1 --- a/mixer.c	Sat Sep 28 10:34:29 2013 -0700
     1.2 +++ b/mixer.c	Sun Oct 13 20:03:03 2013 -0700
     1.3 @@ -36,6 +36,7 @@
     1.4  #include "load_ogg.h"
     1.5  #include "load_flac.h"
     1.6  #include "dynamic_flac.h"
     1.7 +#include "dynamic_fluidsynth.h"
     1.8  #include "dynamic_modplug.h"
     1.9  #include "dynamic_mod.h"
    1.10  #include "dynamic_mp3.h"