Skip to content

Commit

Permalink
Fixed bug 1352 - timidity MIDI playback plays drums that should be mu…
Browse files Browse the repository at this point in the history
…sical notes

manuel.montezelo@gmail.com 2011-12-28 11:42:44 PST
Hi,

I am forwarding the bug reported in Debian:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575575

The submitter requests the following (patch attached here as well):
"When using timidity MIDI playback, music played in MIDI channels 10 and
16 are interpreted as drums.  Really, only channel 10 should default to
drums, according to the MIDI standard; drums on channel 16 are a
Microsoft substandard. :)

To fix this misfeature, please apply the attached patch.  Contrary to
what the comment above the affected line says, this is *not* a runtime
option in SDL_mixer, as far as I can tell."
  • Loading branch information
slouken committed Dec 31, 2011
1 parent 44c1a2c commit 5e947c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion timidity/config.h
Expand Up @@ -26,7 +26,7 @@
On the other hand, some files know that 16 is not a drum channel and
try to play music on it. This is now a runtime option, so this isn't
a critical choice anymore. */
#define DEFAULT_DRUMCHANNELS ((1<<9) | (1<<15))
#define DEFAULT_DRUMCHANNELS (1<<9)

/* A somewhat arbitrary frequency range. The low end of this will
sound terrible as no lowpass filtering is performed on most
Expand Down

0 comments on commit 5e947c9

Please sign in to comment.