Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Max Horn to SDL
Unfortunately, this release does not compile on Mac OS X 10.5 anymore, due to using AudioComponentDescription, which is 10.6 only; yet the #ifdef's introduced recently (in revision 5190) assume it is available on 10.5, too.

To make it work right, one would have to check whether compiling for 10.6 *and* whether one is compiling using the 10.6 SDK. Note that
 #if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_5
would not fix this, either, since MAC_OS_X_VERSION_MIN_REQUIRED can be e.g. 1058 (the actual value on my system); you'd want something like
 #if MAC_OS_X_VERSION_MIN_REQUIRED < 1060
instead (since MAC_OS_X_VERSION_10_6 is not defined on older systems).

With the attached patch, it compiles again on my 10.5/intel/32bit system.
  • Loading branch information
slouken committed Nov 10, 2009
1 parent 8817e4f commit a4e4356
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion native_midi/native_midi_macosx.c
Expand Up @@ -107,7 +107,7 @@ GetSequenceAudioUnit(MusicSequence sequence, AudioUnit *aunit)
if (AUGraphGetIndNode(graph, i, &node) != noErr)
continue; /* better luck next time. */

#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_4 /* this is deprecated, but works back to 10.0 */
#if MAC_OS_X_VERSION_MIN_REQUIRED < 1060 /* this is deprecated, but works back to 10.0 */
{
struct ComponentDescription desc;
UInt32 classdatasize = 0;
Expand Down

0 comments on commit a4e4356

Please sign in to comment.