Tue, 24 Aug 2004 07:49:17 +0000*** empty log message ***
Sam Lantinga <slouken@libsdl.org> [Tue, 24 Aug 2004 07:49:17 +0000] rev 247
*** empty log message ***

Sun, 22 Aug 2004 07:55:14 +0000Martin_Storsj� - Sun, 22 Aug 2004 02:21:14 +0300 (EEST)
Sam Lantinga <slouken@libsdl.org> [Sun, 22 Aug 2004 07:55:14 +0000] rev 246
Martin_Storsj� - Sun, 22 Aug 2004 02:21:14 +0300 (EEST)
* Added SDL_RWops support for reading Ogg Vorbis files

Sat, 21 Aug 2004 12:27:02 +0000Here are patches for SDL12 and SDL_mixer for 4 or 6 channel
Sam Lantinga <slouken@libsdl.org> [Sat, 21 Aug 2004 12:27:02 +0000] rev 245
Here are patches for SDL12 and SDL_mixer for 4 or 6 channel
surround sound on Linux using the Alsa driver. To use them, naturally
you need a sound card that will do 4 or 6 channels and probably also a
recent version of the Alsa drivers and library. Since the only SDL
output driver that knows about surround sound is the Alsa driver,
you���ll want to choose it, using:

export SDL_AUDIODRIVER=alsa

There are no syntactic changes to the programming API. No new
library calls, no differences in arguments.

There are two semantic changes:

(1) For library calls with number of channels as an argument, formerly
you could use only 1 or 2 for the number of channels. Now you
can also use 4 or 6.

(2) The two "left" and "right" arguments to Mix_SetPanning, for the
case of 4 or 6 channels, no longer simply control the volumes of
the left and right channels. Now the "left" argument is converted
to an angle and Mix_SetPosition is called, and the "right" argu-
ment is ignored.

With two exceptions, so far as I know, the modified SDL12 and
SDL_mixer work the same way as the original versions, when opened for
1 or 2 channel output. The two exceptions are bugs which I fixed.
Well, the first, anyway, is a bug for sure. When rate conversions up
or down by a factor of two are applied (in src/audio/SDL_audiocvt.c),
streams with different numbers of channels (that is, mono and stereo)
are treated the same way: either each sample is copied or every other
sample is omitted. This is ok for mono, but for stereo, it is frames
that should be copied or omitted, where by "frame" I mean a portion of
the stream containing one sample for each channel. (In the SDL source,
confusingly, sometimes frames are called "samples".) So for these
rate conversions, stereo streams have to be treated differently, and
they are, in my modified version.

The other problem that might be characterized as a bug arises
when SDL_mixer is passed a multichannel chunk which does not have an
integral number of frames. Due to the way the effect_position code
loops over frames, when the chunk ends with a partial frame, memory
outside the chunk buffer will be accessed. In the case of stereo,
it���s possible that because malloc may give more memory than requested,
this potential problem never actually causes a segment fault. I don���t
know. For 6 channel chunks, I do know, and it does cause segment
faults.


If SDL_mixer is passed defective chunks and this causes a segment
fault, arguably, that���s not a bug in SDL_mixer. Still, whether or not
it counts as a bug, it���s easy to protect against, so why not? I added
code in mixer.c to discard any partial frame at the end of a chunk.

Then what about when SDL or SDL_mixer is opened for 4 or 6 chan-
nel output? What happens with the parts of the current library
designed for stereo? I don���t know whether I���ve covered all the bases,
but I���ve tried:

(1) For playing 2 channel waves, or other cases where SDL knows it has
to match up a 2 channel source with a 4 or 6 channel output, I���ve
added code in SDL_audiocvt.c to make the necessary conversions.

(2) For playing midis using timidity, I���ve converted timidity to do 4
or 6 channel output, upon request.

(3) For playing mods using mikmod, I put ad hoc code in music.c to
convert the stereo output that mikmod produces to 4 or 6 chan-
nels. Obviously it would be better to change the mikmod code to
mix down into 4 or 6 channels, but I have a hard time following
the code in mikmod, so I didn���t do that.

(4) For playing mp3s, I put ad hoc code in smpeg to copy channels in
the case when 4 or 6 channel output is needed.

(5) There seems to be no problem with .ogg files - stereo .oggs can be
up converted as .wavs are.

(6) The effect_position code in SDL_mixer is now generalized to in-
clude the cases of 4 and 6 channel streams.

I���ve done a very limited amount of compatibility testing for some
of the games using SDL I happen to have. For details, see the file
TESTS.

I���ve put into a separate archive, Surround-SDL-testfiles.tgz, a
couple of 6 channel wave files for testing and a 6 channel ogg file.
If you have the right hardware and version of Alsa, you should be able
to play the wave files with the Alsa utility aplay (and hear all
channels, except maybe lfe, for chan-id.wav, since it���s rather faint).
Don���t expect aplay to give good sound, though. There���s something
wrong with the current version of aplay.

The canyon.ogg file is to test loading of 6 channel oggs. After
patching and compiling, you can play it with playmus. (My version of
ogg123 will not play it, and I had to patch mplayer to get it to play
6 channel oggs.)

Greg Lee <greg@ling.lll.hawaii.edu>
Thus, July 1, 2004

Fri, 20 Aug 2004 19:32:09 +0000Date: Wed, 04 Aug 2004 02:55:32 +0200
Sam Lantinga <slouken@libsdl.org> [Fri, 20 Aug 2004 19:32:09 +0000] rev 244
Date: Wed, 04 Aug 2004 02:55:32 +0200
From: Josselin Mouette
Subject: SDL_Mixer and MikMod

I've been told SDL_mixer is responsible for namespace pollution. The
case is an application that links to both mikmod and SDL_mixer.
SDL_mixer unnecessarily exports the mikmod symbols, creating confusion
at linking stage.

I've just tested the following fix for Makefile.am. It allows to export
only the documented symbols of SDL_mixer.

Sun, 18 Jul 2004 18:43:48 +0000Date: Sat, 17 Jul 2004 11:53:18 +0200
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Jul 2004 18:43:48 +0000] rev 243
Date: Sat, 17 Jul 2004 11:53:18 +0200
From: Josselin Mouette
Subject: Re: Bug#259834: sdl-mixer1.2: FTBFS with gcc-3.4: label at end of compo

On ven, 2004-07-16 at 23:17 +0200, Andreas Jochens wrote:

> When building 'sdl-mixer1.2' with gcc-3.4 I get the following error:
>
> In file included from native_midi_gpl.c:32:
> playmidi.h:17:1: warning: "/*" within comment
> native_midi_gpl.c: In function `native_midi_start':
> native_midi_gpl.c:277: error: label at end of compound statement
> make[2]: *** [native_midi_gpl.lo] Error 1
> make[2]: Leaving directory `/sdl-mixer1.2-1.2.5/native_midi_gpl'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/sdl-mixer1.2-1.2.5'
> make: *** [debian/stamp-makefile-build] Error 2
>
> With the attached patch 'sdl-mixer1.2' can be compiled using gcc-3.4.
>
> Regards
> Andreas Jochens

Sun, 18 Jul 2004 18:41:33 +0000ate: Sun, 04 Jul 2004 11:53:23 +0200
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Jul 2004 18:41:33 +0000] rev 242
ate: Sun, 04 Jul 2004 11:53:23 +0200
From: Josselin Mouette
Subject: Re: sdl 64bit problem [PATCH]

Le sam, 03/07/2004 � 18:20 +0200, Hans-Frieder Vogt a �crit :
> Hi list,
>
> I found the problem that lead to the distorted sound in tuxracer on AMD64. It
> may have also been the cause for the other reported sound problems with SDL.
> The problem is not in SDL, but in SDL-mixer.
> There, music files (*.it, and probably others as well) are incorrectly read on
> all 64 bit architectures but Alpha, due to an incorrect data type definition.
> The attached patch should solve the problem for all 64 bit architectures on
> Linux, since at least cpp defines _LP64 and __LP64__ for them.
> _LP64 indicates that long ints and pointers are 64 bits, but integers are 32
> bits.
> I am not sure whether the usage of _LP64 is also standard for the commercial
> compilers, and for other Unixes, but at least Solaris 9 defines _LP64 in the
> 64 bit environment as well.
>
> Josselin,
> could you include this patch into your next debian packages?

Certainly. Sam, could you please include it in the CVS as well?

Sun, 04 Jan 2004 17:41:55 +0000Updated copyright information for 2004 (Happy New Year!)
Sam Lantinga <slouken@libsdl.org> [Sun, 04 Jan 2004 17:41:55 +0000] rev 241
Updated copyright information for 2004 (Happy New Year!)

Wed, 19 Nov 2003 08:38:34 +0000Sam Lantinga - Wed Nov 19 00:23:44 PST 2003
Sam Lantinga <slouken@libsdl.org> [Wed, 19 Nov 2003 08:38:34 +0000] rev 240
Sam Lantinga - Wed Nov 19 00:23:44 PST 2003
* Updated libtool support for new mingw32 DLL build process

Mon, 10 Nov 2003 04:35:47 +0000Updated.
Ryan C. Gordon <icculus@icculus.org> [Mon, 10 Nov 2003 04:35:47 +0000] rev 239
Updated.

Mon, 10 Nov 2003 04:33:21 +0000Hi,
Ryan C. Gordon <icculus@icculus.org> [Mon, 10 Nov 2003 04:33:21 +0000] rev 238
Hi,

The attached patch for SDL_mixer CVS adds missing casts in two
effect_position.c functions; without them, the result is noise, as
SDL_SwapLE16's return value is unsigned. Because SDL_SwapLE16 currently
does nothing on LE systems, this error only shows up on BE systems.

Maybe for consistency, all of the SDL_endian.h functions / macros should
cast their results to Uint16/32/64?

Thanks,


Steven Fuller