Fixed bug 1801 - typo in the xcf decoder, condition is always false

blaffablaffa I'm compiling sdl_image with clang, and it gives this warning: IMG_xcf.c:523:28: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] l = (Uint8)(0.2990 * ((a && 0x00FF0000) >> 16) This is of course always false, because (a && 0x00FF0000) is '1', so if shifted gives always 0. There are a couple of other similar issues in the same file.
libsdl-org · Apr 17, 2013 · 9e3a9f9 · 9e3a9f9
1 parent cbe3dfb
commit 9e3a9f9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/IMG_xcf.c b/IMG_xcf.c
@@ -520,9 +520,9 @@ static unsigned char * load_xcf_tile_rle (SDL_RWops * src, Uint32 len, int bpp,
 
 static Uint32 rgb2grey (Uint32 a) {
   Uint8 l;
-  l = (Uint8)(0.2990 * ((a && 0x00FF0000) >> 16)
-    + 0.5870 * ((a && 0x0000FF00) >>  8)
-    + 0.1140 * ((a && 0x000000FF)));
+  l = (Uint8)(0.2990 * ((a & 0x00FF0000) >> 16)
+    + 0.5870 * ((a & 0x0000FF00) >>  8)
+    + 0.1140 * ((a & 0x000000FF)));
 
   return (l << 16) | (l << 8) | l;
 }