Fixed bug 4538 - validate image size when loading BMP files

libsdl-org · Jul 30, 2019 · 5c146d2 · 5c146d2
1 parent b765138
commit 5c146d2
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/IMG_bmp.c b/IMG_bmp.c
@@ -351,6 +351,11 @@ static SDL_Surface *LoadBMP_RW (SDL_RWops *src, int freesrc)
             SDL_RWseek(src, (biSize - headerSize), RW_SEEK_CUR);
         }
     }
+    if (biWidth <= 0 || biHeight == 0) {
+        IMG_SetError("BMP file with bad dimensions (%dx%d)", biWidth, biHeight);
+        was_error = SDL_TRUE;
+        goto done;
+    }
     if (biHeight < 0) {
         topDown = SDL_TRUE;
         biHeight = -biHeight;