Fixed bug 3474 - IMG_tif leaks memory on errors

Daniel TIFFClose() is not called if TIFFReadRGBAImage() fails.
libsdl-org · Nov 1, 2016 · 15f68ba · 15f68ba
1 parent 78606e0
commit 15f68ba
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/IMG_tif.c b/IMG_tif.c
@@ -204,7 +204,7 @@ int IMG_isTIF(SDL_RWops* src)
 SDL_Surface* IMG_LoadTIF_RW(SDL_RWops* src)
 {
     Sint64 start;
-    TIFF* tiff;
+    TIFF* tiff = NULL;
     SDL_Surface* surface = NULL;
     Uint32 img_width, img_height;
     Uint32 Rmask, Gmask, Bmask, Amask;
@@ -263,9 +263,12 @@ SDL_Surface* IMG_LoadTIF_RW(SDL_RWops* src)
 
 error:
     SDL_RWseek(src, start, RW_SEEK_SET);
-    if ( surface ) {
+    if (surface) {
         SDL_FreeSurface(surface);
     }
+    if (tiff) {
+        lib.TIFFClose(tiff);
+    }
     return NULL;
 }