From 5c146d2b6504d01eb4e502f1a50c21043a9736d4 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Tue, 30 Jul 2019 11:00:12 -0700 Subject: [PATCH] Fixed bug 4538 - validate image size when loading BMP files --- IMG_bmp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/IMG_bmp.c b/IMG_bmp.c index dc54f8ab..8ace1272 100644 --- a/IMG_bmp.c +++ b/IMG_bmp.c @@ -351,6 +351,11 @@ static SDL_Surface *LoadBMP_RW (SDL_RWops *src, int freesrc) SDL_RWseek(src, (biSize - headerSize), RW_SEEK_CUR); } } + if (biWidth <= 0 || biHeight == 0) { + IMG_SetError("BMP file with bad dimensions (%dx%d)", biWidth, biHeight); + was_error = SDL_TRUE; + goto done; + } if (biHeight < 0) { topDown = SDL_TRUE; biHeight = -biHeight;