Commercial-OSS-on-Solaris patch...
authorRyan C. Gordon <icculus@icculus.org>
Thu, 08 Sep 2005 07:15:44 +0000
changeset 1138fcfb783a3ca2
parent 1137 0f9d463bf09c
child 1139 d0ae4dff7208
Commercial-OSS-on-Solaris patch...

--ryan.



Date: Sun, 14 Aug 2005 23:06:40 -0500
From: Shawn Walker <binarycrusader@gmail.com>
To: sdl@libsdl.org
Subject: [SDL] [PATCH] Audio Detection Bug

When using the OSS commercial drivers under Solaris 10, SDL will not
properly initialise OSS audio support (dsp) if /dev/sound exists.
Under Solaris (as far as I understand) /dev/sound is provided as a
means of accessing a BSD style audio device, not the OSS device.

SDL assumes that if /dev/sound exists, then it must be running on a
Linux 2.4 system and should make the dsp device path /dev/sound/dsp.
This is wrong. When using the OSS commercial drivers under Solaris,
the dsp device is always referenced as /dev/dsp normally.

My proposed fix is to stat the dsp device in /dev/sound to make sure
it exists, before assuming /dev/sound/dsp as the audio device:

http://icculus.org/~eviltypeguy/SDL_audiodev.patch

I'm sure there may be a better way to do it, but the above patch is
what worked for me.

--=20
Shawn Walker, Software and Systems Analyst
binarycrusader@gmail.com - http://binarycrusader.blogspot.com/
src/audio/SDL_audiodev.c
     1.1 --- a/src/audio/SDL_audiodev.c	Thu Sep 08 06:49:20 2005 +0000
     1.2 +++ b/src/audio/SDL_audiodev.c	Thu Sep 08 07:15:44 2005 +0000
     1.3 @@ -68,8 +68,8 @@
     1.4  			struct stat sb;
     1.5  
     1.6  			/* Added support for /dev/sound/\* in Linux 2.4 */
     1.7 -			if ( (stat("/dev/sound", &sb) == 0) &&
     1.8 -			     S_ISDIR(sb.st_mode) ) {
     1.9 +			if ( ((stat("/dev/sound", &sb) == 0) && S_ISDIR(sb.st_mode)) &&
    1.10 +				 ((stat(_PATH_DEV_DSP24, &sb) == 0) && S_ISCHR(sb.st_mode)) ) {
    1.11  				audiodev = _PATH_DEV_DSP24;
    1.12  			} else {
    1.13  				audiodev = _PATH_DEV_DSP;