Skip to content

Commit

Permalink
macOS: Fix the coordinate space of SDL_GetDisplayUsableBounds (thanks…
Browse files Browse the repository at this point in the history
… Tim!)

Fixes bug #4518.
  • Loading branch information
slime73 committed Jun 12, 2019
1 parent 74e86a5 commit 50f5123
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/video/cocoa/SDL_cocoamodes.m
Expand Up @@ -300,13 +300,9 @@
return -1;
}

const CGRect cgrect = CGDisplayBounds(cgdisplay);
const NSRect frame = [screen visibleFrame];

// !!! FIXME: I assume -[NSScreen visibleFrame] is relative to the origin of the screen in question and not the whole desktop.
// !!! FIXME: The math vs CGDisplayBounds might be incorrect if that's not the case, though. Check this.
rect->x = (int)(cgrect.origin.x + frame.origin.x);
rect->y = (int)(cgrect.origin.y + frame.origin.y);
rect->x = (int)frame.origin.x;
rect->y = (int)(CGDisplayPixelsHigh(kCGDirectMainDisplay) - frame.origin.y - frame.size.height);
rect->w = (int)frame.size.width;
rect->h = (int)frame.size.height;

Expand Down

0 comments on commit 50f5123

Please sign in to comment.