Skip to content

Commit

Permalink
Date: Tue, 1 Nov 2005 20:25:10 +0100
Browse files Browse the repository at this point in the history
From: Dirk Mueller
Subject: [PATCH] build SDL with nonexecutable stack


libSDL is by default marked with an executable stack, which it doesn't
actually need. the reason for this is that there are assembler files in the
source tree not properly annotated with the "noexec stack" section. As such
the linker does a safe-fallback and marks the whole lib as "requires
executable stack".

the patch below removes this by adding annotations. As far as I can see it
shouldn't break anything.
  • Loading branch information
slouken committed Nov 1, 2005
1 parent 2fe1e4f commit 2d83974
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/hermes/mmx_main.asm
Expand Up @@ -13,6 +13,7 @@ GLOBAL _ConvertMMX
GLOBAL _mmxreturn


SECTION .note.GNU-stack noalloc progbits noexec nowrite
SECTION .text
;; _ConvertMMX:
Expand Down
1 change: 1 addition & 0 deletions src/hermes/mmxp2_32.asm
Expand Up @@ -29,6 +29,7 @@ GLOBAL _ConvertMMXpII32_16BGR555

EXTERN _mmxreturn
SECTION .note.GNU-stack noalloc progbits noexec nowrite
SECTION .data
ALIGN 8
Expand Down
2 changes: 1 addition & 1 deletion src/hermes/x86_main.asm
Expand Up @@ -16,7 +16,7 @@ GLOBAL _x86return
GLOBAL _Hermes_X86_CPU


SECTION .note.GNU-stack noalloc progbits noexec nowrite
SECTION .data
cpu_flags dd 0
Expand Down
2 changes: 1 addition & 1 deletion src/hermes/x86p_16.asm
Expand Up @@ -27,7 +27,7 @@ GLOBAL _ConvertX86p16_8RGB332
EXTERN _ConvertX86
EXTERN _x86return


SECTION .note.GNU-stack noalloc progbits noexec nowrite
SECTION .text


Expand Down
3 changes: 2 additions & 1 deletion src/hermes/x86p_32.asm
Expand Up @@ -24,7 +24,8 @@ GLOBAL _ConvertX86p32_16BGR555
GLOBAL _ConvertX86p32_8RGB332

EXTERN _x86return
SECTION .note.GNU-stack noalloc progbits noexec nowrite
SECTION .text


Expand Down

0 comments on commit 2d83974

Please sign in to comment.