Fixed bug 3723 - Possible double free in kmsdrm init code on certain …

…errors Simon Hug KMSDRM_VideoInit allocates and frees some connectors and encoders but doesn't set the pointer to NULL after freeing. The cleanup code at the end may free one of those garbage pointer should an error happen in the initialization.
libsdl-org · Aug 11, 2017 · a05522a · a05522a
1 parent d0b46f1
commit a05522a
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/video/kmsdrm/SDL_kmsdrmvideo.c b/src/video/kmsdrm/SDL_kmsdrmvideo.c
@@ -325,6 +325,7 @@ KMSDRM_VideoInit(_THIS)
         }
 
         KMSDRM_drmModeFreeConnector(connector);
+        connector = NULL;
     }
 
     if (i == resources->count_connectors) {
@@ -345,6 +346,7 @@ KMSDRM_VideoInit(_THIS)
         }
 
         KMSDRM_drmModeFreeEncoder(encoder);
+        encoder = NULL;
     }
 
     if (i == resources->count_encoders) {