Fixed compiler warnings in Watcom C.

libsdl-org · Oct 3, 2005 · 490defa · 490defa
1 parent bc9d5e7
commit 490defa
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 6 deletions.
diff --git a/test/testcdrom.c b/test/testcdrom.c
@@ -2,8 +2,9 @@
 /* Test the SDL CD-ROM audio functions */
 
 #include <stdlib.h>
-#include <stdio.h>
 #include <ctype.h>
+#include <stdlib.h>
+#include <string.h>
 
 #include "SDL.h"
 

diff --git a/test/testkeys.c b/test/testkeys.c
@@ -3,6 +3,8 @@
 
 #include <stdio.h>
 #include <ctype.h>
+#include <stdlib.h>
+#include <string.h>
 
 #include "SDL.h"
 

diff --git a/test/testtypes.c b/test/testtypes.c
@@ -1,8 +1,20 @@
 
 #include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
 #include "SDL_main.h"
 #include "SDL_types.h"
 
+/*
+ * Watcom C flags these as Warning 201: "Unreachable code" if you just
+ *  compare them directly, so we push it through a function to keep the
+ *  compiler quiet.  --ryan.
+ */
+static int badsize(size_t sizeoftype, size_t hardcodetype)
+{
+    return sizeoftype != hardcodetype;
+}
+
 int main(int argc, char *argv[])
 {
 	int error = 0;
@@ -11,26 +23,26 @@ int main(int argc, char *argv[])
 	if ( argv[1] && (strcmp(argv[1], "-q") == 0) )
 		verbose = 0;
 
-	if ( sizeof(Uint8) != 1 ) {
+	if ( badsize(sizeof(Uint8), 1) ) {
 		if ( verbose )
 			printf("sizeof(Uint8) != 1, instead = %d\n",
 								sizeof(Uint8));
 		++error;
 	}
-	if ( sizeof(Uint16) != 2 ) {
+	if ( badsize(sizeof(Uint16), 2) ) {
 		if ( verbose )
 			printf("sizeof(Uint16) != 2, instead = %d\n",
 								sizeof(Uint16));
 		++error;
 	}
-	if ( sizeof(Uint32) != 4 ) {
+	if ( badsize(sizeof(Uint32), 4) ) {
 		if ( verbose )
 			printf("sizeof(Uint32) != 4, instead = %d\n",
 								sizeof(Uint32));
 		++error;
 	}
 #ifdef SDL_HAS_64BIT_TYPE
-	if ( sizeof(Uint64) != 8 ) {
+	if ( badsize(sizeof(Uint64), 8) ) {
 		if ( verbose )
 			printf("sizeof(Uint64) != 8, instead = %d\n",
 								sizeof(Uint64));

diff --git a/test/testver.c b/test/testver.c
@@ -4,6 +4,7 @@
 */
 
 #include <stdio.h>
+#include <stdlib.h>
 
 #include "SDL.h"
 

diff --git a/test/torturethread.c b/test/torturethread.c
@@ -22,7 +22,7 @@ static void quit(int rc)
 
 int SubThreadFunc(void *data) {
 	while(! *(int volatile *)data) {
-		; /*SDL_Delay(10); /* do nothing */
+		; /*SDL_Delay(10);*/  /* do nothing */
 	}
 	return 0;
 }