Added more strict warning flags.

Fixed bugs/issues uncovered by warning flags.
libsdl-org · Jul 9, 2009 · 02811c7 · 02811c7
1 parent baad3c6
commit 02811c7
Show file tree

Hide file tree

Showing 5 changed files with 631 additions and 635 deletions.
diff --git a/test/automated/Makefile b/test/automated/Makefile
@@ -1,6 +1,6 @@
 
 
-CFLAGS  := -I. `sdl-config --cflags`
+CFLAGS  := -W -Wall -Wextra -I. `sdl-config --cflags`
 LDFLAGS := `sdl-config --libs`
 
 # If it doesn't pick up defaults

diff --git a/test/automated/SDL_at.c b/test/automated/SDL_at.c
@@ -63,7 +63,7 @@ int SDL_ATfinish( int verbose )
    /* Make sure initialized. */
    if (at_suite_msg == NULL) {
       SDL_ATprint("Ended testcase without initializing.\n");
-      return;
+      return 1;
    }
 
    /* Display message if verbose on failed. */
@@ -160,7 +160,7 @@ int SDL_ATprint( const char *msg, ... )
 
    /* Make sure there is something to print. */
    if (msg == NULL)
-      return;
+      return 0;
    else {
       va_start(ap, msg);
       ret = vprintf(msg, ap);

diff --git a/test/automated/rwops/rwops.c b/test/automated/rwops/rwops.c
@@ -155,7 +155,6 @@ static void rwops_testFP (void)
 #ifdef HAVE_STDIO_H
    FILE *fp;
    SDL_RWops *rw;
-   int i;
 
    /* Begin testcase. */
    SDL_ATbegin( "SDL_RWFromFP" );
@@ -189,6 +188,9 @@ static void rwops_testFP (void)
  */
 int main( int argc, const char *argv[] )
 {
+   (void) argc;
+   (void) argv;
+
    SDL_ATinit( "SDL_RWops" );
 
    rwops_testMem();