Code will never reach SDL_SetTexturePalette since SDL_SetDisplayPalette

will fail if the display e.g. is RGB32 or RGB24. The patch will ignore errors in SDL_SetDislayPalette. This should also affect the opengl renderer on systems supporting paletted textures - mine does not (NVIDIA). With this patch the directfb drivers delivers the same results for test_palette like the software renderer. Kind regards, Andr?
libsdl-org · Sep 27, 2010 · dc9b6f1 · dc9b6f1
1 parent f2e0f4a
commit dc9b6f1
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/SDL_compat.c b/src/SDL_compat.c
@@ -321,7 +321,10 @@ SDL_VideoPaletteChanged(void *userdata, SDL_Palette * palette)
     }
     if (userdata == SDL_VideoSurface) {
         if (SDL_SetDisplayPalette(palette->colors, 0, palette->ncolors) < 0) {
-            return -1;
+        	/* The display surface not necessarily needs to have a palette.
+        	 * Just do nothing here and try to set the texture palette.
+        	 */
+            //return -1;
         }
         if (SDL_SetTexturePalette
             (SDL_VideoTexture, palette->colors, 0, palette->ncolors) < 0) {