Skip to content

Commit

Permalink
Mac Classic and CodeWarrior patches.
Browse files Browse the repository at this point in the history
--ryan.



From: =?ISO-8859-1?Q?Anders_F_Bj=F6rklund?= <afb@algonet.se>
Subject: Re: [SDL] Updated Mac patch
Date: Tue, 6 Sep 2005 15:21:27 +0200
To: A list for developers using the SDL library <sdl@libsdl.org>

Earlier, I wrote:

> Updated the previous Mac patch to disable Carbon by default.
> Also "fixed" the SDL.spec again, so that it builds on Darwin.
>
> http://www.algonet.se/~afb/SDL-1.2.9-mac.patch
> Also applied fine to SDL12 CVS, when I tried it.
>
> Haven't completed any new packaging or projects for Xcode/PB,
> but it seems to build and install fine here (in development).

Tested the new patch to build with old CodeWarrior and MPW,
and it seems it needed some hacks with those old headers...

Just in case you want to support the archeological versions -
here is a small add-on to the above patch, to fix those...

http://www.algonet.se/~afb/SDL-1.2.9-classic.patch


I couldn't get the old CW5 projects to build without a few
modifications - such as deleting the stray old header in:
"CWprojects/Support/Carbon/Include/ConditionalMacros.h" ?

But I updated both projects to CW6 too and built for Carbon,
and it ran all of the Mac test projects without any problems.
The MPW file seems to have compiled, with a small order change.


As long as you're still shipping the CWProjects and MPWmake
with the download, they should probably be updated/fixed ?
(another "solution" would of course be to just delete them)

I'll post my new projects along with the new Xcode projects
later on, along with XML exports of the various .mcp files.
(CW5 builds for Classic / "PPC", and CW6 builds for Carbon)


It'll be packaged as a part of the next SpriteWorld X release...
http://spriteworldx.sourceforge.net/  [Classic/Carbon/Win/X11]

--anders
  • Loading branch information
icculus committed Sep 8, 2005
1 parent 1f5dcac commit 671d6f3
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
1 change: 1 addition & 0 deletions src/SDL_loadso.c
Expand Up @@ -37,6 +37,7 @@ static char rcsid =
# include <be/kernel/image.h>
#elif defined(macintosh)
# include <string.h>
#define OLDP2C 1
# include <Strings.h>
# include <CodeFragments.h>
# include <Errors.h>
Expand Down
3 changes: 3 additions & 0 deletions src/audio/macrom/SDL_romaudio.c
Expand Up @@ -42,6 +42,9 @@ static char rcsid =
#if !defined(NewSndCallBackProc) /* avoid circular redefinition... */
#define NewSndCallBackUPP NewSndCallBackProc
#endif
#if !defined(NewSndCallBackUPP)
#define NewSndCallBackUPP NewSndCallBackProc
#endif
#endif

#include "SDL_endian.h"
Expand Down
10 changes: 5 additions & 5 deletions src/joystick/win32/SDL_mmjoystick.c
Expand Up @@ -87,7 +87,7 @@ static char *GetJoystickName(int index, const char *szRegKey)
unsigned char regvalue[256];
unsigned char regname[256];

sprintf(regkey, "%s\\%s\\%s",
sprintf((char *) regkey, "%s\\%s\\%s",
REGSTR_PATH_JOYCONFIG,
szRegKey,
REGSTR_KEY_JOYCURR);
Expand All @@ -100,20 +100,20 @@ static char *GetJoystickName(int index, const char *szRegKey)
joystick's properties
*/
regsize = sizeof(regname);
sprintf(regvalue,
sprintf((char *) regvalue,
"Joystick%d%s", index+1,
REGSTR_VAL_JOYOEMNAME);
regresult = RegQueryValueExA(hKey,
regvalue, 0, 0, (LPBYTE) &regname,
(char *) regvalue, 0, 0, (LPBYTE) &regname,
(LPDWORD) &regsize);
RegCloseKey(hKey);
if (regresult == ERROR_SUCCESS)
{
/* open that registry key */
sprintf(regkey, "%s\\%s",
sprintf((char *) regkey, "%s\\%s",
REGSTR_PATH_JOYOEM, regname);
regresult = RegOpenKeyExA(HKEY_LOCAL_MACHINE,
regkey, 0, KEY_READ, &hKey);
(char *) regkey, 0, KEY_READ, &hKey);
if (regresult == ERROR_SUCCESS)
{
/* find the size for the OEM name text */
Expand Down
6 changes: 4 additions & 2 deletions src/video/macdsp/SDL_dspvideo.c
Expand Up @@ -520,9 +520,11 @@ static int DSp_GetMainDevice (_THIS, GDHandle *device)

static int DSp_VideoInit(_THIS, SDL_PixelFormat *vformat)
{
NumVersion dsp_version;
NumVersion dsp_version = { 0x01, 0x00, 0x00, 0x00 };

#if UNIVERSAL_INTERFACES_VERSION > 0x0320
dsp_version = DSpGetVersion ();
#endif

if ( (dsp_version.majorRev == 1 && dsp_version.minorAndBugRev < 0x73) ||
(dsp_version.majorRev < 1) ) {
Expand Down Expand Up @@ -801,7 +803,7 @@ static SDL_Surface *DSp_SetVideoMode(_THIS,
attrib.colorNeeds = kDSpColorNeeds_Require;
attrib.colorTable = 0;
attrib.pageCount = page_count;
#if TARGET_API_MAC_OSX
#if TARGET_API_MAC_OSX || UNIVERSAL_INTERFACES_VERSION == 0x0320

if ( DSpFindBestContext (&attrib, &dsp_context) != noErr ) {
SDL_SetError ("DrawSprocket couldn't find a context");
Expand Down

0 comments on commit 671d6f3

Please sign in to comment.