Skip to content

Commit

Permalink
Fixed bug #899
Browse files Browse the repository at this point in the history
 Jeremiah Morris      2009-12-09 16:23:50 PST

Re-enable mouseLocation workaround on 10.4, 10.5

OS X systems before 10.6 have a bug with [NSEvent mouseLocation] if the screen
resolution changes. SDL_QuartzVideo.m contains a workaround for this bug, but
it was placed inside an #ifdef in revision 4762. The comment reads, "I'm
gambling they fixed this by 10.4."

After seeing this bug on several Tiger and Leopard systems (both PPC and
Intel), I can confirm that it's not fixed until 10.6. The workaround doesn't
compile for x86_64/10.6, so I can understand why it was segregated, but it
needs to remain in place for the i386 and ppc versions. The workaround causes
no problems under 10.6, even though it's not necessary there.

Patch is attached with one method of keeping the workaround active on the
systems that need it.
  • Loading branch information
slouken committed Dec 11, 2009
1 parent 2bc0ae1 commit 471f269
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/video/quartz/SDL_QuartzVideo.m
Expand Up @@ -24,7 +24,7 @@
#include "SDL_QuartzVideo.h"
#include "SDL_QuartzWindow.h"

#ifdef __powerpc__ /* I'm gambling they fixed this by 10.4. --ryan. */
#if __MAC_OS_X_VERSION_MIN_REQUIRED < 1060 /* Fixed in Snow Leopard */
/*
Add methods to get at private members of NSScreen.
Since there is a bug in Apple's screen switching code
Expand Down

0 comments on commit 471f269

Please sign in to comment.