Fixed bug 4999 - Palette surface always promoted to alpha (Thanks Cam…

…eron Gutman!) MSVC Static analysis: Incorrect alpha_value check in SDL_render.c (see also bug 4425)
libsdl-org · Feb 23, 2020 · 9a7c2b2 · 9a7c2b2
1 parent dd1d8ab
commit 9a7c2b2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/render/SDL_render.c b/src/render/SDL_render.c
@@ -1167,7 +1167,7 @@ SDL_CreateTextureFromSurface(SDL_Renderer * renderer, SDL_Surface * surface)
     if (fmt->palette) {
         for (i = 0; i < fmt->palette->ncolors; i++) {
             Uint8 alpha_value = fmt->palette->colors[i].a;
-            if (alpha_value != 0 || alpha_value != SDL_ALPHA_OPAQUE) {
+            if (alpha_value != 0 && alpha_value != SDL_ALPHA_OPAQUE) {
                 needAlpha = SDL_TRUE;
                 break;
             }