Skip to content

Commit

Permalink
Fixed function feature test for Visual Studio 2012
Browse files Browse the repository at this point in the history
norfanin

Fixes the version check for some functions that are only present with the MSVC 2013 CRT libraries.

I did my testing wrong and failed to see that 2012 doesn't have these functions. Microsoft implemented them in their upcoming 2013 version, though. The attached patch changes it to the check for the next version.

I also removed the HAVE_ITOA because that would require linking with oldnames.lib and it's easier to just let the SDL implementation take over.
  • Loading branch information
slouken committed Oct 14, 2013
1 parent 2337a68 commit 080c919
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions include/SDL_config_windows.h
Expand Up @@ -128,8 +128,7 @@ typedef unsigned int uintptr_t;
#define HAVE_SIN 1
#define HAVE_SINF 1
#define HAVE_SQRT 1
#if _MSC_VER >= 1700
#define HAVE_ITOA 1
#if _MSC_VER >= 1800
#define HAVE_STRTOLL 1
#define HAVE_SSCANF 1
#define HAVE_COPYSIGN 1
Expand Down

0 comments on commit 080c919

Please sign in to comment.