Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Date: Wed, 22 May 2002 22:30:58 +0300
From: "Mike Gorchak" <mike@malva.com.ua>
Subject: One more QNX patch

Hi !

- Fixed graywin test application. Added properly support for
  window size not equal to 640x480.
- Added support for not aligned pitch of image in SDL_SWSURFACE
  and SDL_HWSURFACE. Using Photon builtin alignes.
- Added memory clear after each malloc to avoid problems in the
  future :)
- Removed unused variables and static variables, fixed some warnings.
- Updated readme.QNX file.
  • Loading branch information
slouken committed May 28, 2002
1 parent 207f204 commit 673a594
Show file tree
Hide file tree
Showing 7 changed files with 47 additions and 31 deletions.
5 changes: 4 additions & 1 deletion README.QNX
@@ -1,4 +1,4 @@
README by Mike Gorchak <mike@malva.ua>
README by Mike Gorchak <mike@malva.ua>, <lestat@i.com.ua>

OpenGL in window mode works well and stable, in fullscreen
mode too, but fullscreen mode has not been heavily tested.
Expand All @@ -16,6 +16,9 @@ Problems:
videomode has.
3. No shared libraries yet. We need manually set flag to
'configure' --disable-shared.
4. Due to Photon API limitation, flag SDL_HWSURFACE supported on-
ly in case of desktop bpp is equal requested bpp in window mo-
de.

Some building issues:

Expand Down
39 changes: 25 additions & 14 deletions src/video/photon/SDL_ph_image.c
Expand Up @@ -38,11 +38,14 @@ int PgWaitHWIdle(void);

int ph_SetupImage(_THIS, SDL_Surface *screen)
{
int type=0;
PgColor_t* palette=NULL;
int type=0;
int bpp;

bpp=screen->format->BitsPerPixel;

/* Determine image type */
switch(screen->format->BitsPerPixel)
switch(bpp)
{
case 8:{
type = Pg_IMAGE_PALETTE_BYTE;
Expand All @@ -65,14 +68,14 @@ int ph_SetupImage(_THIS, SDL_Surface *screen)
}
break;
default:{
fprintf(stderr,"ph_SetupImage(): unsupported bbp = %d\n", screen->format->BitsPerPixel);
fprintf(stderr,"ph_SetupImage(): unsupported bbp = %d\n", bpp);
return -1;
}
break;
}

/* palette emulation code */
if ((screen->format->BitsPerPixel==8) && (desktoppal==SDLPH_PAL_EMULATE))
if ((bpp==8) && (desktoppal==SDLPH_PAL_EMULATE))
{
/* creating image palette */
palette=malloc(_Pg_MAX_PALETTE*sizeof(PgColor_t));
Expand All @@ -81,7 +84,7 @@ int ph_SetupImage(_THIS, SDL_Surface *screen)
/* using shared memory for speed (set last param to 1) */
if ((SDL_Image = PhCreateImage(NULL, screen->w, screen->h, type, palette, _Pg_MAX_PALETTE, 1)) == NULL)
{
fprintf(stderr,"ph_SetupImage: PhCreateImage failed for bpp=8.\n");
fprintf(stderr,"ph_SetupImage(): PhCreateImage failed for bpp=8.\n");
return -1;
}
}
Expand All @@ -94,8 +97,9 @@ int ph_SetupImage(_THIS, SDL_Surface *screen)
return -1;
}
}

screen->pixels = SDL_Image->image;
screen->pitch = SDL_Image->bpl; /* Recalculated pitch, created by PhCreateImage */

this->UpdateRects = ph_NormalUpdate;

Expand All @@ -105,9 +109,12 @@ int ph_SetupImage(_THIS, SDL_Surface *screen)
int ph_SetupOCImage(_THIS, SDL_Surface *screen)
{
int type = 0;
int bpp;

bpp=screen->format->BitsPerPixel;

/* Determine image type */
switch(screen->format->BitsPerPixel)
switch(bpp)
{
case 8: {
type = Pg_IMAGE_PALETTE_BYTE;
Expand All @@ -130,14 +137,16 @@ int ph_SetupOCImage(_THIS, SDL_Surface *screen)
}
break;
default:{
fprintf(stderr,"ph_SetupOCImage(): unsupported bpp = %d\n", screen->format->BitsPerPixel);
fprintf(stderr,"ph_SetupOCImage(): unsupported bpp = %d\n", bpp);
return -1;
}
break;
}

OCImage.FrameData0 = (FRAMEDATA *) malloc((size_t)(sizeof(FRAMEDATA)));
OCImage.FrameData1 = (FRAMEDATA *) malloc((size_t)(sizeof(FRAMEDATA)));
memset(OCImage.FrameData0, 0x00, (size_t)(sizeof(FRAMEDATA)));
memset(OCImage.FrameData1, 0x00, (size_t)(sizeof(FRAMEDATA)));

if(OCImage.direct_context == NULL)
{
Expand All @@ -152,7 +161,7 @@ int ph_SetupOCImage(_THIS, SDL_Surface *screen)
return -1;
}

OCImage.Stride = OCImage.offscreen_context->pitch;
screen->pitch = OCImage.offscreen_context->pitch; /* Recalculated pitch */

if (OCImage.flags & SDL_DOUBLEBUF)
{
Expand Down Expand Up @@ -269,10 +278,6 @@ void ph_UnlockHWSurface(_THIS, SDL_Surface *surface)
return;
}

static PhPoint_t ph_pos;
static PhRect_t ph_rect;
static int i;

void ph_OpenGLUpdate(_THIS, int numrects, SDL_Rect* rects)
{
this->GL_SwapBuffers(this);
Expand All @@ -282,7 +287,11 @@ void ph_OpenGLUpdate(_THIS, int numrects, SDL_Rect* rects)

void ph_NormalUpdate(_THIS, int numrects, SDL_Rect *rects)
{
for ( i=0; i<numrects; ++i )
PhPoint_t ph_pos;
PhRect_t ph_rect;
int i;

for (i=0; i<numrects; ++i)
{
if (rects[i].w==0) /* Clipped? */
{
Expand Down Expand Up @@ -310,6 +319,8 @@ void ph_NormalUpdate(_THIS, int numrects, SDL_Rect *rects)

void ph_OCUpdate(_THIS, int numrects, SDL_Rect *rects)
{
int i;

PhPoint_t zero = {0};
PhArea_t src_rect;
PhArea_t dest_rect;
Expand Down
4 changes: 2 additions & 2 deletions src/video/photon/SDL_ph_mouse.c
Expand Up @@ -67,8 +67,8 @@ WMcursor *ph_CreateWMCursor(_THIS,
/* Allocate and initialize the cursor memory */
if ((cursor = (WMcursor*)malloc(sizeof(WMcursor))) == NULL)
{
SDL_OutOfMemory();
return(NULL);
SDL_OutOfMemory();
return(NULL);
}
memset(cursor,0,sizeof(WMcursor));

Expand Down
7 changes: 4 additions & 3 deletions src/video/photon/SDL_ph_video.c
Expand Up @@ -192,6 +192,7 @@ static int ph_VideoInit(_THIS, SDL_PixelFormat *vformat)
{
exit(EXIT_FAILURE);
}
memset(event, 0x00, EVENT_SIZE);

/* Create the blank cursor */
SDL_BlankCursor = this->CreateWMCursor(this, blank_cdata, blank_cmask,
Expand All @@ -200,17 +201,17 @@ static int ph_VideoInit(_THIS, SDL_PixelFormat *vformat)

if (SDL_BlankCursor == NULL)
{
printf("ph_VideoInit: could not create blank cursor\n");
printf("ph_VideoInit(): could not create blank cursor !\n");
}

if (PgGetGraphicsHWCaps(&my_hwcaps) < 0)
{
fprintf(stderr,"ph_VideoInit: GetGraphicsHWCaps failed!! \n");
fprintf(stderr,"ph_VideoInit(): GetGraphicsHWCaps failed !\n");
}

if (PgGetVideoModeInfo(my_hwcaps.current_video_mode, &my_mode_info) < 0)
{
fprintf(stderr,"ph_VideoInit: PgGetVideoModeInfo failed\n");
fprintf(stderr,"ph_VideoInit(): PgGetVideoModeInfo failed !\n");
}

/* We need to return BytesPerPixel as it in used by CreateRGBsurface */
Expand Down
1 change: 0 additions & 1 deletion src/video/photon/SDL_ph_video.h
Expand Up @@ -75,7 +75,6 @@ struct SDL_PrivateVideoData {
FRAMEDATA *FrameData0;
FRAMEDATA *FrameData1;
int current;
long Stride;
long flags;
} ocimage;

Expand Down
8 changes: 5 additions & 3 deletions src/video/photon/SDL_phyuv.c
Expand Up @@ -210,8 +210,10 @@ SDL_Overlay* ph_CreateYUVOverlay(_THIS, int width, int height, Uint32 format, SD
overlay->hwdata->screen_width = 1024;
overlay->hwdata->screen_height = 768;

overlay->hwdata->FrameData0 = (FRAMEDATA *) malloc((size_t)(sizeof( FRAMEDATA)));
overlay->hwdata->FrameData1 = (FRAMEDATA *) malloc((size_t)(sizeof( FRAMEDATA)));
overlay->hwdata->FrameData0 = (FRAMEDATA *) malloc((size_t)(sizeof(FRAMEDATA)));
overlay->hwdata->FrameData1 = (FRAMEDATA *) malloc((size_t)(sizeof(FRAMEDATA)));
memset(overlay->hwdata->FrameData0, 0x00, (size_t)(sizeof(FRAMEDATA)));
memset(overlay->hwdata->FrameData1, 0x00, (size_t)(sizeof(FRAMEDATA)));

overlay->hwdata->caps.size = sizeof(overlay->hwdata->caps);

Expand Down Expand Up @@ -493,7 +495,7 @@ if(overlay == NULL)
//Lock gets the pointer and passes it to the app. The app writes all yuv data into overlay->pixels
//Note this is defined as Uint8 **pixels; /* Read-write */
overlay->pixels = &overlay->hwdata->CurrentFrameData->Y;
overlay->pitches = &overlay->hwdata->YStride;
overlay->pitches = (Uint16*) &(overlay->hwdata->YStride);

return(0);
}
Expand Down
14 changes: 7 additions & 7 deletions test/graywin.c
Expand Up @@ -15,7 +15,7 @@
#endif

/* Draw a randomly sized and colored box centered about (X,Y) */
void DrawBox(SDL_Surface *screen, int X, int Y)
void DrawBox(SDL_Surface *screen, int X, int Y, int width, int height)
{
static unsigned int seeded = 0;
SDL_Rect area;
Expand All @@ -28,8 +28,8 @@ void DrawBox(SDL_Surface *screen, int X, int Y)
}

/* Get the bounds of the rectangle */
area.w = (rand()%640);
area.h = (rand()%480);
area.w = (rand()%width);
area.h = (rand()%height);
area.x = X-(area.w/2);
area.y = Y-(area.h/2);
color = (rand()%NUM_COLORS);
Expand Down Expand Up @@ -72,7 +72,7 @@ SDL_Surface *CreateScreen(Uint16 w, Uint16 h, Uint8 bpp, Uint32 flags)
}
buffer = (Uint8 *)screen->pixels;
for ( i=0; i<screen->h; ++i ) {
memset(buffer,(i*(NUM_COLORS-1))/screen->h, screen->w);
memset(buffer,(i*(NUM_COLORS-1))/screen->h, screen->w * screen->format->BytesPerPixel);
buffer += screen->pitch;
}
SDL_UnlockSurface(screen);
Expand Down Expand Up @@ -126,7 +126,7 @@ int main(int argc, char *argv[])
if ( argv[argc] && (strcmp(argv[argc], "-fullscreen") == 0) ) {
videoflags |= SDL_FULLSCREEN;
} else {
fprintf(stderr, "Usage: %s [-warp] [-fullscreen]\n",
fprintf(stderr, "Usage: %s [-width] [-height] [-bpp] [-hw] [-hwpalette] [-noframe] [-fullscreen]\n",
argv[0]);
exit(1);
}
Expand All @@ -143,7 +143,7 @@ int main(int argc, char *argv[])
while ( !done && SDL_WaitEvent(&event) ) {
switch (event.type) {
case SDL_MOUSEBUTTONDOWN:
DrawBox(screen, event.button.x, event.button.y);
DrawBox(screen, event.button.x, event.button.y, width, height);
break;
case SDL_KEYDOWN:
/* Ignore ALT-TAB for windows */
Expand All @@ -153,7 +153,7 @@ int main(int argc, char *argv[])
}
/* Center the mouse on <SPACE> */
if ( event.key.keysym.sym == SDLK_SPACE ) {
SDL_WarpMouse(640/2, 480/2);
SDL_WarpMouse(width/2, height/2);
break;
}
/* Toggle fullscreen mode on <RETURN> */
Expand Down

0 comments on commit 673a594

Please sign in to comment.