Fixed bug 2868 - SDL_FillRect can crash if surface's clip-rect is out…

…-of-bounds Thanks to John Skaller for the research into this, and for the fix!
libsdl-org · Feb 23, 2015 · d6c4296 · d6c4296
1 parent 8321efb
commit d6c4296
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/video/SDL_fillrect.c b/src/video/SDL_fillrect.c
@@ -251,6 +251,10 @@ SDL_FillRect(SDL_Surface * dst, const SDL_Rect * rect, Uint32 color)
         rect = &clipped;
     } else {
         rect = &dst->clip_rect;
+        /* Don't attempt to fill if the surface's clip_rect is empty */
+        if (SDL_RectEmpty(rect)) {
+            return 0;
+        }
     }
 
     /* Perform software fill */