Static analysis fix: leaking Objective-C object.

libsdl-org · Mar 20, 2014 · a25bd63 · a25bd63
1 parent 84b919a
commit a25bd63
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/video/cocoa/SDL_cocoaevents.m b/src/video/cocoa/SDL_cocoaevents.m
@@ -159,13 +159,19 @@ - (BOOL)application:(NSApplication *)theApplication openFile:(NSString *)filenam
     NSMenu *windowMenu;
     NSMenu *viewMenu;
     NSMenuItem *menuItem;
+    NSMenu *mainMenu;
 
     if (NSApp == nil) {
         return;
     }
-
+
+    mainMenu = [[NSMenu alloc] init];
+
     /* Create the main menu bar */
-    [NSApp setMainMenu:[[NSMenu alloc] init]];
+    [NSApp setMainMenu:mainMenu];
+
+    [mainMenu release];  /* we're done with it, let NSApp own it. */
+    mainMenu = nil;
 
     /* Create the application menu */
     appName = GetApplicationName();