[SDL] Bad math in SDL_RenderCopy

Mason Wheeler to sdl When I tried to render an image using something other than NULL for srcrect, it got horribly distorted. I traced it down to the fact that the math in the rectangle adjustments performed just before the call to renderer->RenderCopy is written inside out. It should look like this: if (dstrect->w != real_dstrect.w) { int deltax = (dstrect->x - real_dstrect.x); int deltaw = (dstrect->w - real_dstrect.w); real_srcrect.x += (deltax * real_srcrect.w) / dstrect->w; real_srcrect.w += (deltaw * real_srcrect.w) / dstrect->w; } if (dstrect->h != real_dstrect.h) { int deltay = (dstrect->y - real_dstrect.y); int deltah = (dstrect->h - real_dstrect.h); real_srcrect.y += (deltay * real_srcrect.h) / dstrect->h; real_srcrect.h += (deltah * real_srcrect.h) / dstrect->h;
libsdl-org · Oct 3, 2009 · 03a11ca · 03a11ca
1 parent 34ec4fe
commit 03a11ca
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c
@@ -2463,14 +2463,14 @@ SDL_RenderCopy(SDL_TextureID textureID, const SDL_Rect * srcrect,
         if (dstrect->w != real_dstrect.w) {
             int deltax = (real_dstrect.x - dstrect->x);
             int deltaw = (real_dstrect.w - dstrect->w);
-            real_srcrect.x += (deltax * dstrect->w) / real_srcrect.w;
-            real_srcrect.w += (deltaw * dstrect->w) / real_srcrect.w;
+            real_srcrect.x += (deltax * real_srcrect.w) / dstrect->w;
+            real_srcrect.w += (deltaw * real_srcrect.w) / dstrect->w;
         }
         if (dstrect->h != real_dstrect.h) {
             int deltay = (real_dstrect.y - dstrect->y);
             int deltah = (real_dstrect.h - dstrect->h);
-            real_srcrect.y += (deltay * dstrect->h) / real_srcrect.h;
-            real_srcrect.h += (deltah * dstrect->h) / real_srcrect.h;
+            real_srcrect.y += (deltay * real_srcrect.h) / dstrect->h;
+            real_srcrect.h += (deltah * real_srcrect.h) / dstrect->h;
         }
     }