Skip to content

Commit

Permalink
x11: Fixed incorrect function signature for XkbSetDetectableAutoRepeat.
Browse files Browse the repository at this point in the history
It needs to use Bool (which is an int) and not BOOL (which is CARD8), which
causes problems on platforms with different byte order and alignment, etc.

Fixes Bugzilla #4326.
  • Loading branch information
icculus committed Oct 21, 2018
1 parent 1fb20f0 commit 1ec56f7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/video/x11/SDL_x11keyboard.c
Expand Up @@ -266,7 +266,7 @@ X11_InitKeyboard(_THIS)
int best_distance;
int best_index;
int distance;
BOOL xkb_repeat = 0;
Bool xkb_repeat = 0;

X11_XAutoRepeatOn(data->display);

Expand Down
2 changes: 1 addition & 1 deletion src/video/x11/SDL_x11sym.h
Expand Up @@ -180,7 +180,7 @@ SDL_X11_SYM(Status,XkbGetUpdatedMap,(Display* a,unsigned int b,XkbDescPtr c),(a,
SDL_X11_SYM(XkbDescPtr,XkbGetMap,(Display* a,unsigned int b,unsigned int c),(a,b,c),return)
SDL_X11_SYM(void,XkbFreeClientMap,(XkbDescPtr a,unsigned int b, Bool c),(a,b,c),)
SDL_X11_SYM(void,XkbFreeKeyboard,(XkbDescPtr a,unsigned int b, Bool c),(a,b,c),)
SDL_X11_SYM(BOOL,XkbSetDetectableAutoRepeat,(Display* a, BOOL b, BOOL* c),(a,b,c),return)
SDL_X11_SYM(Bool,XkbSetDetectableAutoRepeat,(Display* a, Bool b, Bool* c),(a,b,c),return)
#endif

#if NeedWidePrototypes
Expand Down

0 comments on commit 1ec56f7

Please sign in to comment.