Fixed bug #281 SDL-1.2
authorSam Lantinga <slouken@libsdl.org>
Sun, 24 Sep 2006 01:27:40 +0000
branchSDL-1.2
changeset 387781f66f258d77
parent 3876 cf4744dbb1cf
child 3878 678576473849
Fixed bug #281

------- Comment #2 From Christian Walther 2006-07-23 07:37 [reply] -------

Wow, that was an interesting bug to chase. It was a timing issue: it seems that
for some reason, a certain time must pass between ShowMenuBar() being called in
QZ_UnsetVideoMode() and the application quitting. Before rev. 1885, this delay
was provided by the slow hand-coded fade. With the asynchronous Core Graphics
fading introduced in rev. 1885, that delay was no longer present (most of the
time) and the bug became apparent. Adding an SDL_Delay(100) somewhere between
ShowMenuBar() and the end of QZ_VideoQuit() lowered the frequency of the bug
appearing from "almost every time" to "very rarely" here.

However, there is another solution: doing the ShowMenuBar() before releasing
the captured display instead of afterwards. Apparently, no delay is necessary
in that case, and it looks nicer to me anyway because it is the reverse order
of the way things are set up in the beginning: capture display - set video mode
- hide menu bar - ... - show menu bar - reset video mode - release captured
display. So, this is what the attached patch does.

In addition, I've taken the liberty of
- removing some unused code that I forgot to remove in rev. 1885,
- fixing two warnings about undeclared functions in SDL_QuartzVideo.m by
including OpenGL.h (whose name is a bit misleading - it only declares CGL
stuff, so there's no interference with SDL_opengl.h).
src/video/quartz/SDL_QuartzVideo.h
src/video/quartz/SDL_QuartzVideo.m
     1.1 --- a/src/video/quartz/SDL_QuartzVideo.h	Sun Sep 24 00:55:00 2006 +0000
     1.2 +++ b/src/video/quartz/SDL_QuartzVideo.h	Sun Sep 24 01:27:40 2006 +0000
     1.3 @@ -54,7 +54,7 @@
     1.4  #include <Cocoa/Cocoa.h>
     1.5  #include <Carbon/Carbon.h>
     1.6  #include <QuickTime/QuickTime.h>
     1.7 -#include <OpenGL/CGLTypes.h>	/* For CGLContextObj */
     1.8 +#include <OpenGL/OpenGL.h>	/* For CGL functions and types */
     1.9  #include <IOKit/IOKitLib.h>	/* For powersave handling */
    1.10  #include <pthread.h>
    1.11  
     2.1 --- a/src/video/quartz/SDL_QuartzVideo.m	Sun Sep 24 00:55:00 2006 +0000
     2.2 +++ b/src/video/quartz/SDL_QuartzVideo.m	Sun Sep 24 01:27:40 2006 +0000
     2.3 @@ -43,21 +43,6 @@
     2.4  @end
     2.5  
     2.6  
     2.7 -/* 
     2.8 -    Structure for rez switch gamma fades
     2.9 -    We can hide the monitor flicker by setting the gamma tables to 0
    2.10 -*/
    2.11 -#define QZ_GAMMA_TABLE_SIZE 256
    2.12 -
    2.13 -typedef struct {
    2.14 -
    2.15 -    CGGammaValue red[QZ_GAMMA_TABLE_SIZE];
    2.16 -    CGGammaValue green[QZ_GAMMA_TABLE_SIZE];
    2.17 -    CGGammaValue blue[QZ_GAMMA_TABLE_SIZE];
    2.18 -
    2.19 -} SDL_QuartzGammaTable;
    2.20 -
    2.21 -
    2.22  /* Bootstrap functions */
    2.23  static int              QZ_Available ();
    2.24  static SDL_VideoDevice* QZ_CreateDevice (int device_index);
    2.25 @@ -385,10 +370,10 @@
    2.26              CGLSetFullScreen (NULL);
    2.27          }
    2.28          if (to_desktop) {
    2.29 +            ShowMenuBar ();
    2.30              /* Restore original screen resolution/bpp */
    2.31              CGDisplaySwitchToMode (display_id, save_mode);
    2.32              CGReleaseAllDisplays ();
    2.33 -            ShowMenuBar ();
    2.34              /* 
    2.35                  Reset the main screen's rectangle
    2.36                  See comment in QZ_SetVideoFullscreen for why we do this