Fixed bug 3751 - DirectFB linux_input disabled by default
authorSam Lantinga
Sun, 13 Aug 2017 20:51:08 -0700
changeset 112696f981ff3dc5f
parent 11268 10bfd8a3ecd8
child 11270 31ce9a8ce2bd
Fixed bug 3751 - DirectFB linux_input disabled by default

Clayton Craft

linux_input module is disabled by default, despite the comments in source code that it is otherwise:

src/video/directfb/SDL_DirectFB_video.c:
devdata->use_linux_input = readBoolEnv(DFBENV_USE_LINUX_INPUT, 0); /* default: on */

src/video/directfb/SDL_DirectFB_video.h:
#define DFBENV_USE_LINUX_INPUT "SDL_DIRECTFB_LINUX_INPUT" /* Default: on */

When using the directfb driver, the linux_input module is suppressed unless the SDL app is started with "SDL_DIRECTFB_LINUX_INPUT=1" set in the environment. I recall seeing at one point that the directfb folks recommended using linux_input over the other input drivers, but I am having trouble locating this recommendation. In any case, I believe that this should really be defaulted to 'on' since it's vastly superior to the other dfb input drivers!
src/video/directfb/SDL_DirectFB_video.c
     1.1 --- a/src/video/directfb/SDL_DirectFB_video.c	Sun Aug 13 20:42:41 2017 -0700
     1.2 +++ b/src/video/directfb/SDL_DirectFB_video.c	Sun Aug 13 20:51:08 2017 -0700
     1.3 @@ -228,8 +228,7 @@
     1.4              DirectFBSetOption("disable-module", "x11input");
     1.5      }
     1.6  
     1.7 -    /* FIXME: Reenable as default once multi kbd/mouse interface is sorted out */
     1.8 -    devdata->use_linux_input = readBoolEnv(DFBENV_USE_LINUX_INPUT, 0);       /* default: on */
     1.9 +    devdata->use_linux_input = readBoolEnv(DFBENV_USE_LINUX_INPUT, 1);       /* default: on */
    1.10  
    1.11      if (!devdata->use_linux_input)
    1.12      {