Skip to content

Commit

Permalink
Fixed bug 2560 - Crash on any input
Browse files Browse the repository at this point in the history
Alex Marshall

On all of my OSX machines running 10.9 (I posted OS as Mac OS X (All) due to there not being a 10.9 selection), I get a crash on any input using SDL 1.2. I've had this issue in both HG 1.2 and final release 1.2 on the website.

Today I got around to trying to fix it; commenting out the two uses of 'field_edit' in src/video/quartz/SQL_QuartzEvents.m fixes the crash and doesn't cause any side effects as far as I can tell.
  • Loading branch information
slouken committed Jun 22, 2014
1 parent 0332e2b commit 02c0253
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/video/quartz/SDL_QuartzEvents.m
Expand Up @@ -345,11 +345,12 @@ static void QZ_DoKey (_THIS, int state, NSEvent *event) {
the scancode/keysym.
*/
if (SDL_TranslateUNICODE && state == SDL_PRESSED) {
[field_edit interpretKeyEvents:[NSArray arrayWithObject:event]];
/* [field_edit interpretKeyEvents:[NSArray arrayWithObject:event]]; */
chars = [ event characters ];
numChars = [ chars length ];
/*
if (numChars > 0)
[field_edit setString:@""];
[field_edit setString:@""];*/
} else {
numChars = 0;
}
Expand Down

0 comments on commit 02c0253

Please sign in to comment.