Fix for issue #1465, Leak in Android_JNI_SetActivityTitle (SDL_SetWin…

…dowTitle) Thanks Martin Gerhardy!
libsdl-org · May 25, 2012 · 0f1520a · 0f1520a
1 parent 24b7ae4
commit 0f1520a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/core/android/SDL_android.cpp b/src/core/android/SDL_android.cpp
@@ -259,7 +259,9 @@ extern "C" void Android_JNI_SetActivityTitle(const char *title)
 
     mid = mEnv->GetStaticMethodID(mActivityClass,"setActivityTitle","(Ljava/lang/String;)V");
     if (mid) {
-        mEnv->CallStaticVoidMethod(mActivityClass, mid, mEnv->NewStringUTF(title));
+        jstring jtitle = reinterpret_cast<jstring>(mEnv->NewStringUTF(title));
+        mEnv->CallStaticVoidMethod(mActivityClass, mid, jtitle);
+        mEnv->DeleteLocalRef(jtitle);
     }
 }