Date: Sat, 10 Apr 2004 02:25:33 -0400
authorSam Lantinga <slouken@libsdl.org>
Sun, 11 Apr 2004 19:54:40 +0000
changeset 88350f5a29c6a17
parent 882 9301b429c99f
child 884 20d3a599f601
Date: Sat, 10 Apr 2004 02:25:33 -0400
From: Glenn Maynard
To: sdl@libsdl.org
Subject: [SDL] SDL_SetVideoMode() failing and not setting an error (patch)

Running an OpenGL SDL application off 1.2.7, at SDL_InitSubSystem(SDL_INIT_VIDEO) time:

Warning: Unable to initialize AAlib mouseUsing AAlib driver: Slang driver 1.0 (slang)

SDL_SetVideoMode then fails; SDL_GetError() returns "".

The installation problem is straightforward: X (the higher priority
driver) isn't running, so SDL is falling back on aalib. However,
no error is being set when aalib fails to initialize. This also
happens with the svgalib driver.

SDL_video.c line ~653 sets mode to NULL, since aalib didn't return an
OpenGL surface. Line ~711 ("failed setting a video mode") returns NULL.
The attached patch sets an error. It's a horrible, useless error
message--it should really say eg. "aalib does not support OpenGL"; this
should probably be done earlier in the individual drivers, too.
src/video/SDL_video.c
     1.1 --- a/src/video/SDL_video.c	Sun Apr 11 19:52:58 2004 +0000
     1.2 +++ b/src/video/SDL_video.c	Sun Apr 11 19:54:40 2004 +0000
     1.3 @@ -661,6 +661,7 @@
     1.4  	    /* Sam - If we asked for OpenGL mode, and didn't get it, fail */
     1.5  	    if ( is_opengl && !(mode->flags & SDL_OPENGL) ) {
     1.6  		mode = NULL;
     1.7 +		SDL_SetError("OpenGL not available");
     1.8  	    }
     1.9  	}
    1.10  	/*