Skip to content

Commit

Permalink
ignore hot plugs in mac haptic layer IF hap tics hasn't been initiali…
Browse files Browse the repository at this point in the history
…zed.
  • Loading branch information
urkle committed Feb 7, 2014
1 parent c2f6ab0 commit fff7503
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions src/haptic/darwin/SDL_syshaptic.c
Expand Up @@ -85,7 +85,7 @@ static int HIDGetDeviceProduct(io_service_t dev, char *name);

static SDL_hapticlist_item *SDL_hapticlist = NULL;
static SDL_hapticlist_item *SDL_hapticlist_tail = NULL;
static int numhaptics = 0;
static int numhaptics = -1;

/*
* Like strerror but for force feedback errors.
Expand Down Expand Up @@ -155,6 +155,11 @@ SDL_SYS_HapticInit(void)
CFDictionaryRef match;
io_service_t device;

if (numhaptics != -1) {
return SDL_Error("Haptic subsystem already initialized!");
}
numhaptics = 0;

/* Get HID devices. */
match = IOServiceMatching(kIOHIDDeviceKey);
if (match == NULL) {
Expand Down Expand Up @@ -214,6 +219,10 @@ MacHaptic_MaybeAddDevice( io_object_t device )
CFTypeRef refCF;
SDL_hapticlist_item *item;

if (numhaptics == -1) {
return -1; /* not initialized. We'll pick these up on enumeration if we init later. */
}

/* Check for force feedback. */
if (FFIsForceFeedback(device) != FF_OK) {
return -1;
Expand Down Expand Up @@ -288,6 +297,10 @@ MacHaptic_MaybeRemoveDevice( io_object_t device )
SDL_hapticlist_item *item;
SDL_hapticlist_item *prev = NULL;

if (numhaptics == -1) {
return -1; /* not initialized. ignore this. */
}

for (item = SDL_hapticlist; item != NULL; item = item->next) {
/* found it, remove it. */
if (IOObjectIsEqualTo((io_object_t) item->dev, device)) {
Expand Down Expand Up @@ -674,7 +687,7 @@ SDL_SYS_HapticQuit(void)
IOObjectRelease(item->dev);
SDL_free(item);
}
numhaptics = 0;
numhaptics = -1;
}


Expand Down

0 comments on commit fff7503

Please sign in to comment.