Fixes #1815, don't release the LocalRef returned by SDL_AndroidGetAct…

…ivity
libsdl-org · Apr 22, 2013 · bfd5036 · bfd5036
1 parent e529f20
commit bfd5036
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/core/android/SDL_android.cpp b/src/core/android/SDL_android.cpp
@@ -1130,13 +1130,18 @@ extern "C" void *SDL_AndroidGetJNIEnv()
     return Android_JNI_GetEnv();
 }
 
+/*
+ * The jobject returned by SDL_AndroidGetActivity is a local reference.
+ * It is the caller's responsibility to properly release it
+ * (using LocalReferenceHolder or manually with env->DeleteLocalRef)
+ */
+
 extern "C" void *SDL_AndroidGetActivity()
 {
-    LocalReferenceHolder refs(__FUNCTION__);
     jmethodID mid;
 
     JNIEnv *env = Android_JNI_GetEnv();
-    if (!refs.init(env)) {
+    if (!env) {
         return NULL;
     }