Date: Sun, 29 Feb 2004 20:28:27 +0200
authorSam Lantinga
Tue, 02 Mar 2004 12:45:22 +0000
changeset 8640c892e99b65b
parent 863 a4853bc3b4f8
child 865 92615154bb68
Date: Sun, 29 Feb 2004 20:28:27 +0200
From: Martin_Storsj
Subject: Slight bug in ESD and aRts

When I experimented with the ALSA-patch, I found a slight bug in the
Load{ESD,ARTS}Library-functions. The check of whether a function pointer
was correctly loaded looks like this right now:

*esd_functions[i].func = SDL_LoadFunction(esd_handle,
esd_functions[i].name);
if ( ! esd_functions[i].func )

Isn't that supposed to be ( ! *esd_functions[i].func )?
src/audio/arts/SDL_artsaudio.c
src/audio/esd/SDL_esdaudio.c
     1.1 --- a/src/audio/arts/SDL_artsaudio.c	Tue Mar 02 12:38:27 2004 +0000
     1.2 +++ b/src/audio/arts/SDL_artsaudio.c	Tue Mar 02 12:45:22 2004 +0000
     1.3 @@ -106,7 +106,7 @@
     1.4  		retval = 0;
     1.5  		for ( i=0; i<SDL_TABLESIZE(arts_functions); ++i ) {
     1.6  			*arts_functions[i].func = SDL_LoadFunction(arts_handle, arts_functions[i].name);
     1.7 -			if ( ! arts_functions[i].func ) {
     1.8 +			if ( !*arts_functions[i].func ) {
     1.9  				retval = -1;
    1.10  				UnloadARTSLibrary();
    1.11  				break;
     2.1 --- a/src/audio/esd/SDL_esdaudio.c	Tue Mar 02 12:38:27 2004 +0000
     2.2 +++ b/src/audio/esd/SDL_esdaudio.c	Tue Mar 02 12:45:22 2004 +0000
     2.3 @@ -101,7 +101,7 @@
     2.4  		retval = 0;
     2.5  		for ( i=0; i<SDL_TABLESIZE(esd_functions); ++i ) {
     2.6  			*esd_functions[i].func = SDL_LoadFunction(esd_handle, esd_functions[i].name);
     2.7 -			if ( ! esd_functions[i].func ) {
     2.8 +			if ( !*esd_functions[i].func ) {
     2.9  				retval = -1;
    2.10  				UnloadESDLibrary();
    2.11  				break;