Skip to content

Commit

Permalink
Date: Sun, 28 Mar 2004 16:38:32 +1200
Browse files Browse the repository at this point in the history
From: Paul Eggleton
Subject: [SDL] Possible memory leak in SDL 1.2.7

Taking a look at this function X11_CreateWMCursor and its companion
X11_FreeWMCursor (in src/video/x11/SDL_x11mouse.c), I can see that
X11_CreateWMCursor is making several calls to XCreatePixmap, but there are no
corresponding calls in X11_FreeWMCursor to XFreePixmap.
  • Loading branch information
slouken committed May 16, 2004
1 parent f3c65c4 commit d375db1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/video/x11/SDL_x11mouse.c
Expand Up @@ -142,6 +142,8 @@ WMcursor *X11_CreateWMCursor(_THIS,
/* Create the cursor */
cursor->x_cursor = XCreatePixmapCursor(SDL_Display, data_pixmap,
mask_pixmap, &black, &white, hot_x, hot_y);
XFreePixmap(SDL_Display, data_pixmap);
XFreePixmap(SDL_Display, mask_pixmap);

/* Release the event thread */
XSync(SDL_Display, False);
Expand Down

0 comments on commit d375db1

Please sign in to comment.