Skip to content

Commit

Permalink
Android: minimum size for IME, so that it takes focus
Browse files Browse the repository at this point in the history
In API 28, 0 width views can't take focus, so if someone tries to position the IME without setting a width, they'll stop getting text events.

Tested on Android 9: with a 0 size, it would send correctly letters a, b, c, etc. but not numbers.
  • Loading branch information
1bsyl committed May 23, 2019
1 parent 7ec514d commit f91b878
Showing 1 changed file with 8 additions and 0 deletions.
Expand Up @@ -1029,6 +1029,14 @@ public ShowTextInputTask(int x, int y, int w, int h) {
this.y = y;
this.w = w;
this.h = h;

/* Minimum size of 1 pixel, so it takes focus. */
if (this.w <= 0) {
this.w = 1;
}
if (this.h + HEIGHT_PADDING <= 0) {
this.h = 1 - HEIGHT_PADDING;
}
}

@Override
Expand Down

0 comments on commit f91b878

Please sign in to comment.