From 6ca112739e63d2480213a427692bba2a658d94e9 Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Wed, 19 Mar 2014 22:43:30 -0400 Subject: [PATCH] Minor comment cleanups in checker-buildbot.sh --- build-scripts/checker-buildbot.sh | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/build-scripts/checker-buildbot.sh b/build-scripts/checker-buildbot.sh index 2e9f30e05bed6..4ecce6154056a 100755 --- a/build-scripts/checker-buildbot.sh +++ b/build-scripts/checker-buildbot.sh @@ -4,8 +4,9 @@ # through Clang's static analyzer and prepare the output to be uploaded # back to the buildmaster. You might find it useful too. -# To use: get CMake from http://cmake.org/ or "apt-get install cmake" or whatever. -# And download checker at http://clang-analyzer.llvm.org/ and unpack it in +# Install Clang (you already have it on Mac OS X, apt-get install clang +# on Ubuntu, etc), +# or download checker at http://clang-analyzer.llvm.org/ and unpack it in # /usr/local ... update CHECKERDIR as appropriate. FINALDIR="$1" @@ -58,9 +59,16 @@ fi mkdir checker-buildbot cd checker-buildbot -#cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER="$CHECKERDIR/libexec/ccc-analyzer" -DSDL_STATIC=OFF .. + +# You might want to do this for CMake-backed builds instead... +#cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER="$CHECKERDIR/libexec/ccc-analyzer" .. + +# ...or run configure without the scan-build wrapper... #CC="$CHECKERDIR/libexec/ccc-analyzer" CFLAGS="-O0" ../configure + +# ...but this works for our buildbots just fine. CFLAGS="-O0" PATH="$CHECKERDIR:$PATH" scan-build -o analysis ../configure + rm -rf analysis PATH="$CHECKERDIR:$PATH" scan-build -o analysis $MAKE mv analysis/* ../analysis