From 78cc73db14b03f43e6b903591c07e1bed2ba5106 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Mon, 22 Dec 2008 04:58:35 +0000 Subject: [PATCH] /* FIXME FIXME FIXME * Window creation fails in the colormap code on DirectColor visuals: * XA_RGB_BEST_MAP not found and could not be created * I'm disabling this for now until Bob can look at it. We don't need * it until we implement the gamma fading using DirectColor RGB ramps */ --- TODO | 3 ++- src/video/x11/SDL_x11modes.c | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 36c852671..1266c3245 100644 --- a/TODO +++ b/TODO @@ -5,7 +5,8 @@ - in progress, software support is done, Ryan is working on OpenGL shaders * Implement desktop video mode change notification? * Implement icon support (with translucency?) - * Add draw blend mode and line drawing support for software renderer and win32 + * Add draw blend mode and line drawing support for win32 + * Have Bob look at why DirectColor visuals fail with XA_RGB_BEST_MAP error * Verify mouse grab support * Properly handle mouse grab with Vista DPI scaling * Make sure the mouse is where it's supposed to be when un-grabbed diff --git a/src/video/x11/SDL_x11modes.c b/src/video/x11/SDL_x11modes.c index 74fd5ac28..14964c181 100644 --- a/src/video/x11/SDL_x11modes.c +++ b/src/video/x11/SDL_x11modes.c @@ -32,7 +32,13 @@ static int get_visualinfo(Display * display, int screen, XVisualInfo * vinfo) { const char *visual_id = SDL_getenv("SDL_VIDEO_X11_VISUALID"); - int use_directcolor = 1; + /* FIXME FIXME FIXME + * Window creation fails in the colormap code on DirectColor visuals: + * XA_RGB_BEST_MAP not found and could not be created + * I'm disabling this for now until Bob can look at it. We don't need + * it until we implement the gamma fading using DirectColor RGB ramps + */ + int use_directcolor = 0; int depth; /* Look for an exact visual, if requested */